Skip to content

[llvm][gold] Fix syntax error #111412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

ilovepi
Copy link
Contributor

@ilovepi ilovepi commented Oct 7, 2024

This seems to have been overlooked in #109847, probably because most
bots don't build w/ gold enabled.

Created using spr 1.3.4
@ilovepi ilovepi requested review from NuriAmari and teresajohnson and removed request for NuriAmari October 7, 2024 17:47
@llvmbot llvmbot added the LTO Link time optimization (regular/full LTO or ThinLTO) label Oct 7, 2024
@llvmbot
Copy link
Member

llvmbot commented Oct 7, 2024

@llvm/pr-subscribers-lto

Author: Paul Kirth (ilovepi)

Changes

This seems to have been overlooked in #109847, probably because most
bots don't build w/ gold enabled.


Full diff: https://github.com/llvm/llvm-project/pull/111412.diff

1 Files Affected:

  • (modified) llvm/tools/gold/gold-plugin.cpp (+1-1)
diff --git a/llvm/tools/gold/gold-plugin.cpp b/llvm/tools/gold/gold-plugin.cpp
index 9304bd4188d9ed..6d0021c85f20fb 100644
--- a/llvm/tools/gold/gold-plugin.cpp
+++ b/llvm/tools/gold/gold-plugin.cpp
@@ -899,7 +899,7 @@ static std::unique_ptr<LTO> createLTO(IndexWriteCallback OnIndexWrite,
     std::string OldPrefix, NewPrefix;
     getThinLTOOldAndNewPrefix(OldPrefix, NewPrefix);
     Backend = createWriteIndexesThinBackend(
-        llvm::hardware_concurrency(options::Parallelism) OldPrefix, NewPrefix,
+        llvm::hardware_concurrency(options::Parallelism), OldPrefix, NewPrefix,
         // TODO: Add support for optional native object path in
         // thinlto_prefix_replace option to match lld.
         /*NativeObjectPrefix=*/"", options::thinlto_emit_imports_files,

@NuriAmari
Copy link
Contributor

Thanks for the fix!

@ilovepi ilovepi merged commit fabe7e3 into main Oct 7, 2024
7 of 8 checks passed
@ilovepi ilovepi deleted the users/ilovepi/spr/llvmgold-fix-syntax-error branch October 7, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTO Link time optimization (regular/full LTO or ThinLTO)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants