Skip to content

[CIR] Add .clang-tidy files for ClangIR specific coding style rules #111417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lanza
Copy link
Member

@lanza lanza commented Oct 7, 2024

Created using spr 1.3.5
@lanza lanza requested a review from bcardosolopes as a code owner October 7, 2024 18:27
Copy link
Collaborator

@erichkeane erichkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a good idea of what the whole list should BE, but htis seems reasonable to me.

Copy link
Contributor

@dkolsen-pgi dkolsen-pgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with how clang-tidy works. (I expect that will have to change and I should start using it.) So I can't meaningfully review this.

@lanza
Copy link
Member Author

lanza commented Oct 7, 2024

I am not familiar with how clang-tidy works. (I expect that will have to change and I should start using it.) So I can't meaningfully review this.

If you use clangd then the clang-tidy based warnings will just show up in your editor. These files are just enforcing the ClangIR specific rules.

@lanza lanza merged commit dd0fe4f into main Oct 7, 2024
7 of 8 checks passed
@lanza lanza deleted the users/lanza/sprcir-add-clang-tidy-files-for-clangir-specific-coding-style-rules branch October 7, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants