Skip to content

[SandboxVectorizer][NFC] Remove unused include #111418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Sterling-Augustine
Copy link
Contributor

No description provided.

@Sterling-Augustine Sterling-Augustine merged commit 3f50393 into llvm:main Oct 7, 2024
5 of 7 checks passed
@llvmbot
Copy link
Member

llvmbot commented Oct 7, 2024

@llvm/pr-subscribers-llvm-transforms

Author: None (Sterling-Augustine)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/111418.diff

1 Files Affected:

  • (modified) llvm/lib/Transforms/Vectorize/SandboxVectorizer/SeedCollector.cpp (+1-2)
diff --git a/llvm/lib/Transforms/Vectorize/SandboxVectorizer/SeedCollector.cpp b/llvm/lib/Transforms/Vectorize/SandboxVectorizer/SeedCollector.cpp
index e8b90386dc8f84..00a7dc3fcec93e 100644
--- a/llvm/lib/Transforms/Vectorize/SandboxVectorizer/SeedCollector.cpp
+++ b/llvm/lib/Transforms/Vectorize/SandboxVectorizer/SeedCollector.cpp
@@ -1,4 +1,4 @@
-//===- SeedCollection.cpp  -0000000----------------------------------------===//
+//===- SeedCollector.cpp  -0000000-----------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -15,7 +15,6 @@
 #include "llvm/SandboxIR/Instruction.h"
 #include "llvm/SandboxIR/Utils.h"
 #include "llvm/Support/Debug.h"
-#include <span>
 
 using namespace llvm;
 namespace llvm::sandboxir {

@jplehr
Copy link
Contributor

jplehr commented Oct 7, 2024

I see this error in some of our bots.

FAILED: unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/builds/openmp-offload-rhel-8.8-build/llvm.build/unittests/Transforms/Vectorize/SandboxVectorizer -I/home/botworker/builds/openmp-offload-rhel-8.8-build/llvm.src/llvm/unittests/Transforms/Vectorize/SandboxVectorizer -I/home/botworker/builds/openmp-offload-rhel-8.8-build/llvm.build/include -I/home/botworker/builds/openmp-offload-rhel-8.8-build/llvm.src/llvm/include -I/home/botworker/builds/openmp-offload-rhel-8.8-build/llvm.src/third-party/unittest/googletest/include -I/home/botworker/builds/openmp-offload-rhel-8.8-build/llvm.src/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -MD -MT unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o -MF unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o.d -o unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o -c /home/botworker/builds/openmp-offload-rhel-8.8-build/llvm.src/llvm/unittests/Transforms/Vectorize/SandboxVectorizer/SeedCollectorTest.cpp
/home/botworker/builds/openmp-offload-rhel-8.8-build/llvm.src/llvm/unittests/Transforms/Vectorize/SandboxVectorizer/SeedCollectorTest.cpp:16:10: fatal error: span: No such file or directory
 #include <span>
          ^~~~~~
compilation terminated.

@Sterling-Augustine
Copy link
Contributor Author

That error should be fixed by this PR.

@jplehr
Copy link
Contributor

jplehr commented Oct 7, 2024

Let me force a clean build then, maybe a ccache glitch. It looked as if the error came from a unit test file not the actual implementation (edit: which this PR fixes).

@Sterling-Augustine
Copy link
Contributor Author

My mistake. The same unused include was in two files.

@jplehr
Copy link
Contributor

jplehr commented Oct 7, 2024

Thank you for double checking.

@Sterling-Augustine
Copy link
Contributor Author

#111422

fixes the other.

Would be really nice to have this as a pre-merge check.

@jplehr
Copy link
Contributor

jplehr commented Oct 7, 2024

I agree, we are working on it.

@Sterling-Augustine Sterling-Augustine deleted the fix branch October 7, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants