Skip to content

[SandboxVectorizer][NFC] Remove erroneous expensive check assert #111425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Sterling-Augustine
Copy link
Contributor

No description provided.

@Sterling-Augustine Sterling-Augustine merged commit e0b840a into llvm:main Oct 7, 2024
7 of 8 checks passed
@llvmbot
Copy link
Member

llvmbot commented Oct 7, 2024

@llvm/pr-subscribers-llvm-transforms

Author: None (Sterling-Augustine)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/111425.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h (-5)
diff --git a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
index 06fb41ac58db2c..460e3f675fa797 100644
--- a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
+++ b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
@@ -50,11 +50,6 @@ class SeedBundle {
   /// by symbol, symbol-offset, and program order (which depends if scheduling
   /// bottom-up or top-down).
   void insertAt(iterator Pos, Instruction *I) {
-#ifdef EXPENSIVE_CHECKS
-    for (auto Itr : Seeds) {
-      assert(*Itr != I && "Attempt to insert an instruction twice.");
-    }
-#endif
     Seeds.insert(Pos, I);
     NumUnusedBits += Utils::getNumBits(I);
   }

@Sterling-Augustine Sterling-Augustine deleted the assert branch October 7, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants