Skip to content

[Transform] Avoid repeated hash lookups (NFC) #111620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@kazutakahirata kazutakahirata requested a review from nikic October 9, 2024 02:21
@llvmbot llvmbot added the mlir label Oct 9, 2024
@llvmbot
Copy link
Member

llvmbot commented Oct 9, 2024

@llvm/pr-subscribers-mlir

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/111620.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/Transform/Transforms/CheckUses.cpp (+3-3)
diff --git a/mlir/lib/Dialect/Transform/Transforms/CheckUses.cpp b/mlir/lib/Dialect/Transform/Transforms/CheckUses.cpp
index 561d3d5b05af64..e6db819b51c22c 100644
--- a/mlir/lib/Dialect/Transform/Transforms/CheckUses.cpp
+++ b/mlir/lib/Dialect/Transform/Transforms/CheckUses.cpp
@@ -39,11 +39,11 @@ template <typename FnTy>
 const llvm::SmallPtrSet<Block *, 4> &
 getReachableImpl(Block *block, FnTy getNextNodes,
                  DenseMap<Block *, llvm::SmallPtrSet<Block *, 4>> &cache) {
-  auto it = cache.find(block);
-  if (it != cache.end())
+  auto [it, inserted] = cache.try_emplace(block);
+  if (!inserted)
     return it->getSecond();
 
-  llvm::SmallPtrSet<Block *, 4> &reachable = cache[block];
+  llvm::SmallPtrSet<Block *, 4> &reachable = it->second;
   SmallVector<Block *> worklist;
   worklist.push_back(block);
   while (!worklist.empty()) {

Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazutakahirata kazutakahirata merged commit 7d9f993 into llvm:main Oct 9, 2024
11 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_repeated_hash_mlir_Transform branch October 9, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants