Skip to content

llvm-reduce: Fix not checking shouldKeep in special-globals reduction #111647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Oct 9, 2024

Fixes "input module no longer interesting after counting chunks"
assertion on cases where llvm.used matters.

Fixes "input module no longer interesting after counting chunks"
assertion on cases where llvm.used matters.
@arsenm arsenm added the llvm-reduce label Oct 9, 2024 — with Graphite App
Copy link
Contributor Author

arsenm commented Oct 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @arsenm and the rest of your teammates on Graphite Graphite

@arsenm arsenm marked this pull request as ready for review October 9, 2024 08:41
Copy link
Member

@jdoerfert jdoerfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough.

@arsenm arsenm merged commit 1731bb7 into main Oct 9, 2024
13 checks passed
@arsenm arsenm deleted the users/arsenm/llvm-reduce-check-shouldkeep-special-globals branch October 9, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants