Skip to content

[ci] Don't add check-all target when pstl project is enabled #111803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

DavidSpickett
Copy link
Collaborator

Fixes #110265

Adding check-all causes us to run some tests twice if a project specific target like check-clang is also added.

check-pstl is an alternative but as far as I can tell, check-all does not include this so we have not been running the tests in CI anyway.

When I tried to run check-pstl locally I got a lot of compiler errors but have not found any instructions on how to setup a correct build environment. Even if such instructions exist, it's probably more than we want to do in CI.

According to Louis Dionne, the project is probably not active. So if it's ever revived it'll be up to the new contributors to enable testing.

Fixes llvm#110265

Adding check-all causes us to run some tests twice if a project
specific target like check-clang is also added.

check-pstl is an alternative but as far as I can tell, check-all
does not include this so we have not been running the tests in CI
anyway.

When I tried to run check-pstl locally I got a lot of compiler
errors but have not found any instructions on how to setup a
correct build environment. Even if such instructions exist,
it's probably more than we want to do in CI.

According to Louis Dionne, the project is probably not active.
So if it's ever revived it'll be up to the new contributors
to enable testing.
@llvmbot
Copy link
Member

llvmbot commented Oct 10, 2024

@llvm/pr-subscribers-github-workflow

Author: David Spickett (DavidSpickett)

Changes

Fixes #110265

Adding check-all causes us to run some tests twice if a project specific target like check-clang is also added.

check-pstl is an alternative but as far as I can tell, check-all does not include this so we have not been running the tests in CI anyway.

When I tried to run check-pstl locally I got a lot of compiler errors but have not found any instructions on how to setup a correct build environment. Even if such instructions exist, it's probably more than we want to do in CI.

According to Louis Dionne, the project is probably not active. So if it's ever revived it'll be up to the new contributors to enable testing.


Full diff: https://github.com/llvm/llvm-project/pull/111803.diff

1 Files Affected:

  • (modified) .ci/generate-buildkite-pipeline-premerge (+4-1)
diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge
index 53a43070bf1ca3..7676ff716c4185 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -191,6 +191,9 @@ function keep-modified-projects() {
 }
 
 function check-targets() {
+  # Do not use "check-all" here because if there is "check-all" plus a
+  # project specific target like "check-clang", that project's tests
+  # will be run twice.
   projects=${@}
   for project in ${projects}; do
     case ${project} in
@@ -216,7 +219,7 @@ function check-targets() {
       echo "check-lldb"
     ;;
     pstl)
-      echo "check-all"
+      # Currently we do not run pstl tests in CI.
     ;;
     libclc)
       # Currently there is no testing for libclc.

@DavidSpickett DavidSpickett merged commit 9014920 into llvm:main Oct 10, 2024
7 checks passed
@DavidSpickett DavidSpickett deleted the ci-pstl branch October 10, 2024 13:26
DanielCChen pushed a commit to DanielCChen/llvm-project that referenced this pull request Oct 16, 2024
…1803)

Fixes llvm#110265

Adding check-all causes us to run some tests twice if a project specific
target like check-clang is also added.

check-pstl is an alternative but as far as I can tell, check-all does
not include this so we have not been running the tests in CI anyway.

When I tried to run check-pstl locally I got a lot of compiler errors
but have not found any instructions on how to setup a correct build
environment. Even if such instructions exist, it's probably more than we
want to do in CI.

According to Louis Dionne, the project is probably not active. So if
it's ever revived it'll be up to the new contributors to enable testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buildkite CI builds that include certain projects are testing clang twice
4 participants