[IPSCCP] Push constant struct params into callees #111805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch pushes constant alloca params into single use callees. This is beneficial in large functions emitted by fortran "box passing" which can combine multiple constant alloca parameters into one large alloca, which then results in duplicate unnecessary constant stores and less clear optimization paths. This only works for CallInsts that have a single use with an alloca parameter, that of which's users are only stores and GEP's that are stored to one layer deep.
MDevereau
changed the title
|
It seems this isn't targeting the same issues as #111163. This issue focuses on a Fortran problem which passes large constant structs to a call. The amount of elements that would needed to be promoted by argpromotion for this particular function is far too big for argpromotion to handle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch pushes constant alloca params into single use callees. This is beneficial in large functions emitted by fortran "box passing" which can combine multiple constant alloca parameters into one large alloca, which then results in duplicate unnecessary constant stores and less clear optimization paths.
This only works for CallInsts that have a single use with an alloca parameter, that of which's users are only stores and GEP's that are stored to one layer deep.