-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[sanitizer] VReport thread status for failed PTRACE_ATTACH #111901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vitalybuka
merged 6 commits into
main
from
users/vitalybuka/spr/sanitizer-vreport-thread-status-for-failed-ptrace_attach
Oct 10, 2024
Merged
[sanitizer] VReport thread status for failed PTRACE_ATTACH #111901
vitalybuka
merged 6 commits into
main
from
users/vitalybuka/spr/sanitizer-vreport-thread-status-for-failed-ptrace_attach
Oct 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Vitaly Buka (vitalybuka) ChangesSuch threads can cause false leak reports, Full diff: https://github.com/llvm/llvm-project/pull/111901.diff 1 Files Affected:
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp
index d9f803a276dadc..a42f6ab1241796 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp
@@ -148,6 +148,14 @@ bool ThreadSuspender::SuspendThread(tid_t tid) {
// Log this event and move on.
VReport(1, "Could not attach to thread %zu (errno %d).\n", (uptr)tid,
pterrno);
+ if (common_flags()->verbosity >= 2) {
+ InternalScopedString path;
+ path.AppendF("/proc/%d/task/%llu/status", pid_, tid);
+ InternalMmapVector<char> buffer;
+ ReadFileToVector(path.data(), &buffer);
+ buffer.push_back(0);
+ VReport(2, "%s: %s\n", path.data(), buffer.data());
+ }
return false;
} else {
VReport(2, "Attached to thread %zu.\n", (uptr)tid);
|
fmayer
approved these changes
Oct 10, 2024
compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp
Outdated
Show resolved
Hide resolved
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
vitalybuka
added a commit
that referenced
this pull request
Oct 10, 2024
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
Such threads can cause false leak reports, but often it's hard to diagnose the reason of failed PTRACE_ATTACH. Maybe we can find a clue from `/proc/*/task/*/status`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such threads can cause false leak reports,
but often it's hard to diagnose the reason of
failed PTRACE_ATTACH. Maybe we can find
a clue from
/proc/*/task/*/status