[asan] Print unique_id instead of tid

[vitalybuka]

Before the first reuse, after 2^32 threads
they are equal.

[llvmbot]

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Vitaly Buka (vitalybuka)

Changes

Before the first reuse, after 2^32 threads
they are equal.

---

Full diff: https://github.com/llvm/llvm-project/pull/111925.diff

1 Files Affected:

• (modified) compiler-rt/lib/asan/asan_descriptions.cpp (+1-1)

diff --git a/compiler-rt/lib/asan/asan_descriptions.cpp b/compiler-rt/lib/asan/asan_descriptions.cpp
index db87789aea86a0..caec79313e22ff 100644
--- a/compiler-rt/lib/asan/asan_descriptions.cpp
+++ b/compiler-rt/lib/asan/asan_descriptions.cpp
@@ -24,7 +24,7 @@ AsanThreadIdAndName::AsanThreadIdAndName(AsanThreadContext *t) {
     internal_snprintf(name, sizeof(name), "T-1");
     return;
   }
-  int len = internal_snprintf(name, sizeof(name), "T%d", t->tid);
+  int len = internal_snprintf(name, sizeof(name), "T%llu", t->unique_id);
   CHECK(((unsigned int)len) < sizeof(name));
   if (internal_strlen(t->name))
     internal_snprintf(&name[len], sizeof(name) - len, " (%s)", t->name);

[fmayer]

Is this an improvement? How will people convert this to the TID, or know that they have to?

[vitalybuka]

Is this an improvement? How will people convert this to the TID, or know that they have to?

TID is not OS ID, TID is just an index in ThreadRegistry array
I think it's not perfect, and we need to replace/add this with OS ID, but it's bigger job.