Skip to content

[NFC][sanitizer] Check suspended threads outside ThreadSuspender::SuspendThread #111943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 11, 2024
Merged

[NFC][sanitizer] Check suspended threads outside ThreadSuspender::SuspendThread #111943

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7e4c836
[𝘀𝗽𝗿] changes to main this commit is based on
vitalybuka Oct 11, 2024
e8284c4
[𝘀𝗽𝗿] initial version
vitalybuka Oct 11, 2024
a6c0fc9
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Oct 11, 2024
fa2a5c3
rebase
vitalybuka Oct 11, 2024
551164f
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Oct 11, 2024
570ba34
rebase
vitalybuka Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,6 @@ class ThreadSuspender {
};

bool ThreadSuspender::SuspendThread(tid_t tid) {
// Are we already attached to this thread?
// Currently this check takes linear time, however the number of threads is
// usually small.
if (suspended_threads_list_.ContainsTid(tid)) return false;
int pterrno;
if (internal_iserror(internal_ptrace(PTRACE_ATTACH, tid, nullptr, nullptr),
&pterrno)) {
Expand Down Expand Up @@ -226,6 +222,11 @@ bool ThreadSuspender::SuspendAllThreads() {
break;
}
for (tid_t tid : threads) {
// Are we already attached to this thread?
// Currently this check takes linear time, however the number of threads
// is usually small.
if (suspended_threads_list_.ContainsTid(tid))
continue;
if (SuspendThread(tid))
retry = true;
else
Expand Down
Loading