-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[compiler-rt][RISCV] Use u64 data type for marchid and mimpid #112163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base on riscv-non-isa/riscv-c-api-doc#91 , the marchid and mimpid are MXLEN bits wide, and kernel returned them as u64 data type. So we should use u64 data type for marchid and mimpid in __riscv_cpu_model struct here. Signed-off-by: Yangyu Chen <[email protected]>
BeMg
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge according to 1 approval. |
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/136/builds/1255 Here is the relevant piece of the build log for the reference
|
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
…12163) Base on riscv-non-isa/riscv-c-api-doc#91 , the marchid and mimpid are MXLEN bits wide, and kernel returned them as u64 data type. So we should use u64 data type for marchid and mimpid in __riscv_cpu_model struct here. Signed-off-by: Yangyu Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on riscv-non-isa/riscv-c-api-doc#91 , the marchid and mimpid are MXLEN bits wide, and kernel returned them as u64 data type. So we should use u64 data type for marchid and mimpid in __riscv_cpu_model struct here.