[mlir][vector] Update document for vector.splat(NFC)
#112363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-vector @llvm/pr-subscribers-mlir Author: Longsheng Mou (CoTinker) ChangesThis PR updates the document for Full diff: https://github.com/llvm/llvm-project/pull/112363.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
index b0de7c11b9d436..a00f4682e67d4f 100644
--- a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
+++ b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
@@ -2807,8 +2807,8 @@ def Vector_SplatOp : Vector_Op<"splat", [
Example:
```mlir
- %s = arith.constant 10.1 : f32
- %t = vector.splat %s : vector<8x16xi32>
+ %s = arith.constant 1.0 : f32
+ %t = vector.splat %s : vector<8x16xf32>
```
}];
|
This PR updates the document for `vector.splat`, specifying that the operand type must match the element type of the result.
|
Thanks for your review. |
dcaballe
approved these changes
Oct 15, 2024
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
This PR updates the document for `vector.splat`, specifying that the operand type must match the element type of the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the document for
vector.splat, specifying that the operand type must match the element type of the result.