Skip to content

clang/HIP: Remove REQUIRES windows from a test #112411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Oct 15, 2024

No description provided.

Copy link
Contributor Author

arsenm commented Oct 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @arsenm and the rest of your teammates on Graphite Graphite

@arsenm arsenm added backend:AMDGPU clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Oct 15, 2024 — with Graphite App
@arsenm arsenm requested review from AlexVlx and yxsamliu October 15, 2024 18:03
@arsenm arsenm marked this pull request as ready for review October 15, 2024 18:04
@llvmbot
Copy link
Member

llvmbot commented Oct 15, 2024

@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-backend-amdgpu

@llvm/pr-subscribers-clang

Author: Matt Arsenault (arsenm)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/112411.diff

1 Files Affected:

  • (modified) clang/test/Driver/hip-runtime-libs-msvc.hip (-2)
diff --git a/clang/test/Driver/hip-runtime-libs-msvc.hip b/clang/test/Driver/hip-runtime-libs-msvc.hip
index 8085e77d457e56..943cd0569f4fd1 100644
--- a/clang/test/Driver/hip-runtime-libs-msvc.hip
+++ b/clang/test/Driver/hip-runtime-libs-msvc.hip
@@ -1,5 +1,3 @@
-// REQUIRES: system-windows
-
 // RUN:  touch %t.o
 
 // Test HIP runtime lib args specified by --rocm-path.

@arsenm arsenm force-pushed the users/arsenm/hip-partial-link-remove-requires-linux branch from b63c440 to 8b57e62 Compare October 16, 2024 05:10
@arsenm arsenm force-pushed the users/arsenm/clang-hip-test-remove-requires-system-windows branch from 61b3467 to ecb5254 Compare October 16, 2024 05:10
@arsenm arsenm force-pushed the users/arsenm/clang-hip-test-remove-requires-system-windows branch from 2bf91dd to 3f41cfc Compare October 16, 2024 15:34
@arsenm arsenm changed the base branch from users/arsenm/hip-partial-link-remove-requires-linux to main October 16, 2024 15:34
Copy link

⚠️ Python code formatter, darker found issues in your code. ⚠️

You can test this locally with the following command:
darker --check --diff -r f3648046ec67b6be1743cc7760fc57820bcdc7f7...3f41cfc5d00ec704953a0474e679108f742de7c9 compiler-rt/test/profile/lit.cfg.py lldb/test/API/commands/expression/import-std-module/array/TestArrayFromStdModule.py lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py lldb/test/API/commands/expression/import-std-module/vector-of-vectors/TestVectorOfVectorsFromStdModule.py llvm/utils/lit/lit/reports.py llvm/utils/lit/tests/shtest-format.py llvm/utils/lit/tests/xunit-output.py
View the diff from darker here.
--- compiler-rt/test/profile/lit.cfg.py	2024-10-16 15:33:56.000000 +0000
+++ compiler-rt/test/profile/lit.cfg.py	2024-10-16 15:38:31.071742 +0000
@@ -76,11 +76,11 @@
             continue
         f = open(source_path, "r")
         try:
             data = f.read()
             # rpath is not supported on AIX, exclude all tests with them.
-            if ( "-rpath" in data ):
+            if "-rpath" in data:
                 config.excludes += [filename]
         finally:
             f.close()
 
 

Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff f3648046ec67b6be1743cc7760fc57820bcdc7f7 3f41cfc5d00ec704953a0474e679108f742de7c9 --extensions ,h,c,cpp -- libc/src/math/exp10m1f16.h libc/src/math/generic/exp10m1f16.cpp libc/test/src/math/exp10m1f16_test.cpp libc/test/src/math/smoke/exp10m1f16_test.cpp llvm/include/llvm/CodeGen/EarlyIfConversion.h clang-tools-extra/clang-tidy/ClangTidy.cpp clang/include/clang/AST/DeclTemplate.h clang/include/clang/ExtractAPI/API.h clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h clang/lib/AST/DeclTemplate.cpp clang/lib/AST/ExprConstant.cpp clang/lib/Basic/Targets/OSTargets.cpp clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Sema/SemaDeclCXX.cpp clang/lib/Sema/SemaOpenACC.cpp clang/lib/Sema/SemaTemplateInstantiate.cpp clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang/lib/StaticAnalyzer/Core/ExprEngine.cpp clang/test/Analysis/string.c clang/test/Analysis/string.cpp clang/test/CXX/temp/temp.constr/temp.constr.decl/p4.cpp clang/test/Driver/cl-options.c clang/test/ExtractAPI/anonymous_record_no_typedef.c clang/test/ExtractAPI/typedef_anonymous_record.c clang/test/Modules/friend-definition-2.cpp clang/test/Preprocessor/predefined-win-macros.c clang/test/SemaCXX/constexpr-builtin-bit-cast.cpp clang/test/SemaCXX/virtual-override.cpp clang/utils/TableGen/MveEmitter.cpp compiler-rt/test/profile/Posix/instrprof-visibility.cpp compiler-rt/test/profile/coverage-inline.cpp compiler-rt/test/profile/coverage_comments.cpp compiler-rt/test/profile/coverage_emptylines.cpp compiler-rt/test/profile/instrprof-merging.cpp compiler-rt/test/profile/instrprof-set-file-object-merging.c compiler-rt/test/profile/instrprof-set-file-object.c compiler-rt/test/profile/instrprof-without-libc.c compiler-rt/test/profile/instrprof-write-file-only.c flang/lib/Evaluate/intrinsics-library.cpp flang/lib/Lower/OpenMP/OpenMP.cpp flang/runtime/Float128Math/math-entries.h libc/src/math/generic/exp10f16.cpp libc/src/math/generic/expxf16.h libc/utils/MPFRWrapper/MPFRUtils.cpp libc/utils/MPFRWrapper/MPFRUtils.h libcxx/include/__ranges/zip_view.h libcxx/include/__split_buffer libcxx/include/future libcxx/test/std/ranges/range.adaptors/range.zip/cpo.pass.cpp libcxx/test/std/ranges/range.adaptors/range.zip/ctor.default.pass.cpp libcxx/test/std/ranges/range.adaptors/range.zip/iterator/compare.pass.cpp libcxx/test/std/ranges/range.adaptors/range.zip/iterator/deref.pass.cpp libcxx/test/std/ranges/range.adaptors/range.zip/iterator/member_types.compile.pass.cpp libcxx/test/std/ranges/range.adaptors/range.zip/iterator/subscript.pass.cpp lld/ELF/Driver.cpp lld/ELF/InputSection.h lld/ELF/Relocations.cpp lld/ELF/SyntheticSections.cpp lld/ELF/SyntheticSections.h lld/ELF/Writer.cpp lldb/source/Core/Progress.cpp llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h llvm/include/llvm/CodeGen/MIRParser/MIParser.h llvm/include/llvm/CodeGen/MachineTraceMetrics.h llvm/include/llvm/CodeGen/Passes.h llvm/include/llvm/CodeGen/SDPatternMatch.h llvm/include/llvm/IR/Intrinsics.h llvm/include/llvm/InitializePasses.h llvm/include/llvm/Passes/CodeGenPassBuilder.h llvm/include/llvm/Transforms/IPO/SampleProfileMatcher.h llvm/lib/Analysis/LazyValueInfo.cpp llvm/lib/Analysis/ScalarEvolution.cpp llvm/lib/Analysis/VectorUtils.cpp llvm/lib/CodeGen/CodeGen.cpp llvm/lib/CodeGen/EarlyIfConversion.cpp llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp llvm/lib/CodeGen/MIRParser/MIRParser.cpp llvm/lib/CodeGen/MachineCombiner.cpp llvm/lib/CodeGen/MachineTraceMetrics.cpp llvm/lib/CodeGen/SafeStack.cpp llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp llvm/lib/CodeGen/StackProtector.cpp llvm/lib/CodeGen/TargetPassConfig.cpp llvm/lib/IR/AutoUpgrade.cpp llvm/lib/IR/Intrinsics.cpp llvm/lib/IR/LegacyPassManager.cpp llvm/lib/LTO/LTO.cpp llvm/lib/Passes/PassBuilder.cpp llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp llvm/lib/Target/AArch64/AArch64ConditionalCompares.cpp llvm/lib/Target/AArch64/AArch64ISelLowering.cpp llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h llvm/lib/Target/AArch64/AArch64StorePairSuppress.cpp llvm/lib/Target/AArch64/AArch64TargetMachine.cpp llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp llvm/lib/Target/AMDGPU/AMDGPULowerKernelArguments.cpp llvm/lib/Target/AMDGPU/AMDGPULowerKernelAttributes.cpp llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h llvm/lib/Target/AMDGPU/SIISelLowering.cpp llvm/lib/Target/ARM/ARMISelLowering.cpp llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp llvm/lib/Target/ARM/Disassembler/ARMDisassembler.cpp llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/lib/Target/PowerPC/PPCTargetMachine.cpp llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp llvm/lib/Target/SystemZ/SystemZISelLowering.cpp llvm/lib/Target/SystemZ/SystemZTargetMachine.cpp llvm/lib/Target/X86/X86ISelLoweringCall.cpp llvm/lib/Target/X86/X86TargetMachine.cpp llvm/lib/Target/X86/X86WinEHState.cpp llvm/lib/Transforms/IPO/ExpandVariadics.cpp llvm/lib/Transforms/IPO/GlobalDCE.cpp llvm/lib/Transforms/IPO/GlobalSplit.cpp llvm/lib/Transforms/IPO/LowerTypeTests.cpp llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp llvm/lib/Transforms/Instrumentation/KCFI.cpp llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp llvm/lib/Transforms/Instrumentation/ThreadSanitizer.cpp llvm/lib/Transforms/Scalar/Float2Int.cpp llvm/lib/Transforms/Scalar/GuardWidening.cpp llvm/lib/Transforms/Scalar/IndVarSimplify.cpp llvm/lib/Transforms/Scalar/JumpThreading.cpp llvm/lib/Transforms/Scalar/LoopPredication.cpp llvm/lib/Transforms/Scalar/LowerGuardIntrinsic.cpp llvm/lib/Transforms/Scalar/LowerWidenableCondition.cpp llvm/lib/Transforms/Scalar/MakeGuardsExplicit.cpp llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp llvm/lib/Transforms/Utils/SCCPSolver.cpp llvm/lib/Transforms/Vectorize/LoopVectorize.cpp llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp llvm/test/tools/llvm-cov/binary-formats.c llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp llvm/unittests/Transforms/Instrumentation/PGOInstrumentationTest.cpp mlir/include/mlir/TableGen/AttrOrTypeDef.h mlir/include/mlir/TableGen/Dialect.h mlir/include/mlir/TableGen/Operator.h mlir/lib/Dialect/Bufferization/Transforms/Bufferize.cpp mlir/lib/Dialect/MLProgram/Transforms/PipelineGlobalOps.cpp mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp mlir/lib/TableGen/AttrOrTypeDef.cpp mlir/lib/TableGen/Attribute.cpp mlir/lib/TableGen/Dialect.cpp mlir/lib/TableGen/Interfaces.cpp mlir/lib/TableGen/Operator.cpp mlir/lib/TableGen/Pattern.cpp mlir/lib/TableGen/Type.cpp mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp mlir/lib/Target/LLVMIR/ModuleTranslation.cpp mlir/lib/Tools/mlir-tblgen/MlirTblgenMain.cpp mlir/tools/mlir-tblgen/BytecodeDialectGen.cpp mlir/tools/mlir-tblgen/DialectGen.cpp mlir/tools/mlir-tblgen/OmpOpGen.cpp polly/lib/CodeGen/BlockGenerators.cpp polly/lib/CodeGen/IslNodeBuilder.cpp polly/lib/CodeGen/LoopGeneratorsGOMP.cpp lldb/test/Shell/SymbolFile/DWARF/x86/no_unique_address-alignment.cpp lldb/test/Shell/SymbolFile/DWARF/x86/no_unique_address-base-alignment.cpp
View the diff from clang-format here.
diff --git a/compiler-rt/test/profile/coverage_emptylines.cpp b/compiler-rt/test/profile/coverage_emptylines.cpp
index 8006cdee6e..035764cfb0 100644
--- a/compiler-rt/test/profile/coverage_emptylines.cpp
+++ b/compiler-rt/test/profile/coverage_emptylines.cpp
@@ -6,7 +6,6 @@
 // RUN: llvm-profdata merge -o %t.profdata %t.profraw
 // RUN: llvm-cov show %t -instr-profile %t.profdata 2>&1 | FileCheck %s
 
-
 int main() {                        // CHECK:       [[# @LINE]]| 1|int main() {
     int x = 0;                      // CHECK-NEXT:  [[# @LINE]]| 1|
                                     // CHECK-NEXT:  [[# @LINE]]|  |
diff --git a/llvm/include/llvm/CodeGen/SDPatternMatch.h b/llvm/include/llvm/CodeGen/SDPatternMatch.h
index b3e249b7eb..1c2a5ba3dc 100644
--- a/llvm/include/llvm/CodeGen/SDPatternMatch.h
+++ b/llvm/include/llvm/CodeGen/SDPatternMatch.h
@@ -832,8 +832,7 @@ inline UnaryOpc_match<Opnd, true> m_ChainedUnaryOp(unsigned Opc,
   return UnaryOpc_match<Opnd, true>(Opc, Op);
 }
 
-template <typename Opnd>
-inline UnaryOpc_match<Opnd> m_BSwap(const Opnd &Op) {
+template <typename Opnd> inline UnaryOpc_match<Opnd> m_BSwap(const Opnd &Op) {
   return UnaryOpc_match<Opnd>(ISD::BSWAP, Op);
 }
 
diff --git a/mlir/tools/mlir-tblgen/BytecodeDialectGen.cpp b/mlir/tools/mlir-tblgen/BytecodeDialectGen.cpp
index 86ebaf2cf2..c61a52c764 100644
--- a/mlir/tools/mlir-tblgen/BytecodeDialectGen.cpp
+++ b/mlir/tools/mlir-tblgen/BytecodeDialectGen.cpp
@@ -135,7 +135,9 @@ void Generator::emitParse(StringRef kind, const Record &x) {
       R"(static {0} read{1}(MLIRContext* context, DialectBytecodeReader &reader) )";
   mlir::raw_indented_ostream os(output);
   std::string returnType = getCType(&x);
-  os << formatv(head, kind == "attribute" ? "::mlir::Attribute" : "::mlir::Type", x.getName());
+  os << formatv(head,
+                kind == "attribute" ? "::mlir::Attribute" : "::mlir::Type",
+                x.getName());
   DagInit *members = x.getValueAsDag("members");
   SmallVector<std::string> argNames =
       llvm::to_vector(map_range(members->getArgNames(), [](StringInit *init) {

@ldionne ldionne removed the request for review from a team October 16, 2024 20:09
@arsenm arsenm merged commit 77ea619 into main Oct 17, 2024
65 of 66 checks passed
@arsenm arsenm deleted the users/arsenm/clang-hip-test-remove-requires-system-windows branch October 17, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:AMDGPU clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants