-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[NFC] Fix flakiness in test if run unsharded #112439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC] Fix flakiness in test if run unsharded #112439
Conversation
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Vitaly Buka (vitalybuka) ChangesIf we run all test in a single process, there is high Full diff: https://github.com/llvm/llvm-project/pull/112439.diff 1 Files Affected:
diff --git a/compiler-rt/lib/sanitizer_common/tests/sanitizer_chained_origin_depot_test.cpp b/compiler-rt/lib/sanitizer_common/tests/sanitizer_chained_origin_depot_test.cpp
index a557c4645ba0c5..61171019a5706d 100644
--- a/compiler-rt/lib/sanitizer_common/tests/sanitizer_chained_origin_depot_test.cpp
+++ b/compiler-rt/lib/sanitizer_common/tests/sanitizer_chained_origin_depot_test.cpp
@@ -31,7 +31,7 @@ TEST(SanitizerCommon, ChainedOriginDepotBasic) {
TEST(SanitizerCommon, ChainedOriginDepotAbsent) {
u32 prev_id;
- EXPECT_EQ(0U, chainedOriginDepot.Get(99, &prev_id));
+ EXPECT_EQ(0U, chainedOriginDepot.Get(123456, &prev_id));
EXPECT_EQ(0U, prev_id);
}
|
(I was told to use |
I don't know meaning of this label, I can find only https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20240722/601293.html which seems irrelevant. |
Ok, it's documented, but it has a different name https://llvm.org/docs/CodeReview.html#code-review-workflow |
If we run all test in a single process, there is high probability that `99` is already claimed.
If we run all test in a single process, there is high
probability that
99
is already claimed.