Skip to content

[NFC] Fix flakiness in test if run unsharded #112439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vitalybuka
Copy link
Collaborator

If we run all test in a single process, there is high
probability that 99 is already claimed.

@llvmbot
Copy link
Member

llvmbot commented Oct 15, 2024

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Vitaly Buka (vitalybuka)

Changes

If we run all test in a single process, there is high
probability that 99 is already claimed.


Full diff: https://github.com/llvm/llvm-project/pull/112439.diff

1 Files Affected:

  • (modified) compiler-rt/lib/sanitizer_common/tests/sanitizer_chained_origin_depot_test.cpp (+1-1)
diff --git a/compiler-rt/lib/sanitizer_common/tests/sanitizer_chained_origin_depot_test.cpp b/compiler-rt/lib/sanitizer_common/tests/sanitizer_chained_origin_depot_test.cpp
index a557c4645ba0c5..61171019a5706d 100644
--- a/compiler-rt/lib/sanitizer_common/tests/sanitizer_chained_origin_depot_test.cpp
+++ b/compiler-rt/lib/sanitizer_common/tests/sanitizer_chained_origin_depot_test.cpp
@@ -31,7 +31,7 @@ TEST(SanitizerCommon, ChainedOriginDepotBasic) {
 
 TEST(SanitizerCommon, ChainedOriginDepotAbsent) {
   u32 prev_id;
-  EXPECT_EQ(0U, chainedOriginDepot.Get(99, &prev_id));
+  EXPECT_EQ(0U, chainedOriginDepot.Get(123456, &prev_id));
   EXPECT_EQ(0U, prev_id);
 }
 

@vitalybuka vitalybuka changed the base branch from users/vitalybuka/spr/main.nfc-fix-flakiness-in-test-if-run-unsharded to main October 15, 2024 21:38
Created using spr 1.3.4
@vitalybuka vitalybuka merged commit 01b78b2 into main Oct 15, 2024
4 of 6 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/nfc-fix-flakiness-in-test-if-run-unsharded branch October 15, 2024 21:40
@fmayer
Copy link
Contributor

fmayer commented Oct 15, 2024

(I was told to use skip-precommit-approval label for CLs that I don't want reviewed)

@vitalybuka
Copy link
Collaborator Author

(I was told to use skip-presubmit-approval label for CLs that I don't want reviewed)

I don't know meaning of this label, I can find only https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20240722/601293.html which seems irrelevant.

@fmayer
Copy link
Contributor

fmayer commented Oct 15, 2024

image

@vitalybuka
Copy link
Collaborator Author

Ok, it's documented, but it has a different name https://llvm.org/docs/CodeReview.html#code-review-workflow

@vitalybuka vitalybuka added the skip-precommit-approval PR for CI feedback, not intended for review label Oct 15, 2024
DanielCChen pushed a commit to DanielCChen/llvm-project that referenced this pull request Oct 16, 2024
If we run all test in a single process, there is high
probability that `99` is already claimed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler-rt:sanitizer compiler-rt skip-precommit-approval PR for CI feedback, not intended for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants