Skip to content

[DXIL] Add GroupMemoryBarrierWithGroupSync intrinsic #112641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

adam-yang
Copy link
Contributor

Example implementation of lowering GroupMemoryBarrierWithGroupSync via new tablegen based method.

Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 29e192a0bfbc75fa66498d3b1c1d1329009f1dd2 36dbb21745a6e1c2581ef35e6af3428d9253de25 --extensions h,cpp -- llvm/lib/Target/DirectX/DXILConstants.h llvm/lib/Target/DirectX/DXILOpLowering.cpp llvm/utils/TableGen/DXILEmitter.cpp
View the diff from clang-format here.
diff --git a/llvm/lib/Target/DirectX/DXILOpLowering.cpp b/llvm/lib/Target/DirectX/DXILOpLowering.cpp
index 1be20cf112..dcda4027ac 100644
--- a/llvm/lib/Target/DirectX/DXILOpLowering.cpp
+++ b/llvm/lib/Target/DirectX/DXILOpLowering.cpp
@@ -473,9 +473,9 @@ public:
       switch (ID) {
       default:
         continue;
-#define DXIL_OP_INTRINSIC(OpCode, Intrin, ExtraArgs)                         \
-  case Intrin:                                                               \
-    HasErrors |= replaceFunctionWithOp(F, OpCode, ExtraArgs);                \
+#define DXIL_OP_INTRINSIC(OpCode, Intrin, ExtraArgs)                           \
+  case Intrin:                                                                 \
+    HasErrors |= replaceFunctionWithOp(F, OpCode, ExtraArgs);                  \
     break;
 #include "DXILOperation.inc"
       case Intrinsic::dx_handle_fromBinding:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant