[lldb] Avoid repeated map lookups (NFC)

[kazutakahirata]

No description provided.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Kazu Hirata (kazutakahirata)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/112655.diff

1 Files Affected:

• (modified) lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (+1-1)

diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index 3e09c316d74f44..70cbd1c57b895a 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -5324,7 +5324,7 @@ std::string ProcessGDBRemote::HarmonizeThreadIdsForProfileData(
         std::map<uint64_t, uint32_t>::iterator iterator =
             m_thread_id_to_used_usec_map.find(thread_id);
         if (iterator != m_thread_id_to_used_usec_map.end()) {
-          prev_used_usec = m_thread_id_to_used_usec_map[thread_id];
+          prev_used_usec = iterator->second;
         }
 
         uint32_t real_used_usec = curr_used_usec - prev_used_usec;

[JDevlieghere]

LGTM

[felipepiovezan]

Thanks for finding those, there are many places in LLDB doing repeated work like this!

[jimingham]

Note that a lot of lldb was written before C++11 was allowed in llvm projects. So looking through code that hasn't been touched recently, you will likely find constructs that could be made more efficient with some of the newer C++ gadgets. We probably shouldn't be doing change just for changes sake, but when we can make the code clearer or more efficient, that's certainly worth doing. Jim

…

On Oct 17, 2024, at 7:23 AM, Felipe de Azevedo Piovezan ***@***.***> wrote: Thanks for finding those, there are many places in LLDB doing repeated work like this! — Reply to this email directly, view it on GitHub <#112655 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW6BHFPRYQ7CN6LZBQTZ37B67AVCNFSM6AAAAABQCZCHMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJZGY4TQNJUG4>. You are receiving this because you are on a team that was mentioned.