Skip to content

[AMDGPU] gfx1152 does not have Feature1_5xVGPRs #113163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

jayfoad
Copy link
Contributor

@jayfoad jayfoad commented Oct 21, 2024

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Oct 21, 2024

@llvm/pr-subscribers-backend-amdgpu

Author: Jay Foad (jayfoad)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/113163.diff

1 Files Affected:

  • (modified) llvm/docs/AMDGPUUsage.rst (-1)
diff --git a/llvm/docs/AMDGPUUsage.rst b/llvm/docs/AMDGPUUsage.rst
index aba39762861dd8..9e623010f6fb7d 100644
--- a/llvm/docs/AMDGPUUsage.rst
+++ b/llvm/docs/AMDGPUUsage.rst
@@ -608,7 +608,6 @@ Generic processor code objects are versioned. See :ref:`amdgpu-generic-processor
                                                                                                 - ``gfx1100``
                                                                                                 - ``gfx1101``
                                                                                                 - ``gfx1151``
-                                                                                                - ``gfx1152``
 
                                                                                                 SALU floating point instructions
                                                                                                 are not available on:

Copy link
Contributor

@shiltian shiltian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the new 1153 just added in another PR?

Didn’t see your comment in another PR. LGTM.

@perlfu
Copy link
Contributor

perlfu commented Oct 22, 2024

@jayfoad I don't understand, the section says "Not all VGPRs can be used on:", i.e. 1.5x VGPRs are not available?

@perlfu
Copy link
Contributor

perlfu commented Oct 22, 2024

@jayfoad I don't understand, the section says "Not all VGPRs can be used on:", i.e. 1.5x VGPRs are not available?

Ignore me, I get it now.
Can we perhaps reword the section title while we are here?

@jayfoad
Copy link
Contributor Author

jayfoad commented Oct 22, 2024

@jayfoad I don't understand, the section says "Not all VGPRs can be used on:", i.e. 1.5x VGPRs are not available?

Ignore me, I get it now.

Yeah, I had the same kind of confusion when I first read it.

@jayfoad jayfoad merged commit e7f1dae into llvm:main Oct 22, 2024
11 checks passed
@jayfoad
Copy link
Contributor Author

jayfoad commented Oct 22, 2024

Can we perhaps reword the section title while we are here?

Feel free to propose your own rewording :)

@jayfoad jayfoad deleted the gfx1152-extra-vgprs branch October 22, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants