Skip to content

[nfc][msan] Generate test with update_test_checks.py #113199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 22, 2024
Merged

[nfc][msan] Generate test with update_test_checks.py #113199

merged 8 commits into from
Oct 22, 2024

Conversation

vitalybuka
Copy link
Collaborator

@vitalybuka vitalybuka commented Oct 21, 2024 •
edited
Loading

PR is to:

  1. Simplify test update in [msan] Switch to -msan-handle-icmp-exact my default #113200
  2. Make tests more comprehensive, currently interesting cases looks very basic:
; CHECK-LABEL: @ICmpSGTAllOnes
; CHECK: icmp slt
; CHECK-NOT: call void @__msan_warning
; CHECK: icmp sgt
; CHECK-NOT: call void @__msan_warning
; CHECK: ret i1

@vitalybuka
[𝘀𝗽𝗿] changes to main this commit is based on
783fff0 
Created using spr 1.3.4

[skip ci]
@vitalybuka
[𝘀𝗽𝗿] initial version
766e661 
Created using spr 1.3.4
@vitalybuka
[𝘀𝗽𝗿] changes introduced through rebase
8e6b4a7 
Created using spr 1.3.4

[skip ci]
@vitalybuka
rebase
8fdb617 
Created using spr 1.3.4
@vitalybuka
[𝘀𝗽𝗿] changes introduced through rebase
f8ee483 
Created using spr 1.3.4

[skip ci]
@vitalybuka
rebase
9d7e97b 
Created using spr 1.3.4
@vitalybuka vitalybuka requested review from fmayer and eugenis October 21, 2024 17:58
@vitalybuka vitalybuka changed the base branch from users/vitalybuka/spr/main.nfcmsan-re-generate-test-with-update_test_checkspy to main October 21, 2024 18:14
@vitalybuka
rebase
74b672c 
Created using spr 1.3.4
@fmayer
Copy link
Contributor

fmayer commented Oct 21, 2024

Not regenerated

@vitalybuka
Copy link
Collaborator Author

Not _re_generated

Please clarify, the patch looks correct to me.

@fmayer
Copy link
Contributor

fmayer commented Oct 22, 2024

Not _re_generated

Please clarify, the patch looks correct to me.

That was a nit about the commit message. "Regenerate" sounds like it was generated with the script before.

@vitalybuka vitalybuka changed the title [nfc][msan] Re-generate test with update_test_checks.py [nfc][msan] Generate test with update_test_checks.py Oct 22, 2024
@vitalybuka
Copy link
Collaborator Author

Not _re_generated

Please clarify, the patch looks correct to me.

That was a nit about the commit message. "Regenerate" sounds like it was generated with the script before.

Changed.
But to me it was fine, before - generated by human, after generated by script, so re-generate. :)

@vitalybuka
rebase
75b230e 
Created using spr 1.3.4
@vitalybuka vitalybuka merged commit 54cf62d into main Oct 22, 2024
6 of 8 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/nfcmsan-re-generate-test-with-update_test_checkspy branch October 22, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmayer fmayer fmayer approved these changes

@eugenis eugenis Awaiting requested review from eugenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitalybuka @fmayer