Skip to content

[lld/Macho][test] Mark objc-category-merging-minimal.s as unsupported on Windows #113209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

aeubanks
Copy link
Contributor

With #112981, the test uses awk, which gnuwin32 doesn't seem to have.

… on Windows

With llvm#112981, the test uses awk, which gnuwin32 doesn't seem to have.
@llvmbot
Copy link
Member

llvmbot commented Oct 21, 2024

@llvm/pr-subscribers-lld

Author: Arthur Eubanks (aeubanks)

Changes

With #112981, the test uses awk, which gnuwin32 doesn't seem to have.


Full diff: https://github.com/llvm/llvm-project/pull/113209.diff

1 Files Affected:

  • (modified) lld/test/MachO/objc-category-merging-minimal.s (+3)
diff --git a/lld/test/MachO/objc-category-merging-minimal.s b/lld/test/MachO/objc-category-merging-minimal.s
index 88c175333f2629..d4d5933aa5ec80 100644
--- a/lld/test/MachO/objc-category-merging-minimal.s
+++ b/lld/test/MachO/objc-category-merging-minimal.s
@@ -1,4 +1,7 @@
 # REQUIRES: aarch64
+# UNSUPPORTED: system-windows
+#   due to awk usage
+
 # RUN: rm -rf %t; split-file %s %t && cd %t
 
 ############ Test merging multiple categories into a single category ############

@llvmbot
Copy link
Member

llvmbot commented Oct 21, 2024

@llvm/pr-subscribers-lld-macho

Author: Arthur Eubanks (aeubanks)

Changes

With #112981, the test uses awk, which gnuwin32 doesn't seem to have.


Full diff: https://github.com/llvm/llvm-project/pull/113209.diff

1 Files Affected:

  • (modified) lld/test/MachO/objc-category-merging-minimal.s (+3)
diff --git a/lld/test/MachO/objc-category-merging-minimal.s b/lld/test/MachO/objc-category-merging-minimal.s
index 88c175333f2629..d4d5933aa5ec80 100644
--- a/lld/test/MachO/objc-category-merging-minimal.s
+++ b/lld/test/MachO/objc-category-merging-minimal.s
@@ -1,4 +1,7 @@
 # REQUIRES: aarch64
+# UNSUPPORTED: system-windows
+#   due to awk usage
+
 # RUN: rm -rf %t; split-file %s %t && cd %t
 
 ############ Test merging multiple categories into a single category ############

Copy link
Contributor

@alx32 alx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing.

@aeubanks aeubanks merged commit dca43a1 into llvm:main Oct 21, 2024
8 of 9 checks passed
@aeubanks aeubanks deleted the awk branch October 21, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants