[libc] Fix fexcept_t type to match canonical ABI and API #113666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In glibc and musl, fexcept_t is unsigned short int on x86 and unsigned int on other machines that llvm-libc supports. Match that ABI (only different from before on x86) and API (different everywhere as it was previously signed).
|
@llvm/pr-subscribers-libc Author: Roland McGrath (frobtech) ChangesIn glibc and musl, fexcept_t is unsigned short int on x86 and Full diff: https://github.com/llvm/llvm-project/pull/113666.diff 1 Files Affected:
diff --git a/libc/include/llvm-libc-types/fexcept_t.h b/libc/include/llvm-libc-types/fexcept_t.h
index 60687bd1318aa4..5aa09fbbaffc77 100644
--- a/libc/include/llvm-libc-types/fexcept_t.h
+++ b/libc/include/llvm-libc-types/fexcept_t.h
@@ -9,6 +9,10 @@
#ifndef LLVM_LIBC_TYPES_FEXCEPT_T_H
#define LLVM_LIBC_TYPES_FEXCEPT_T_H
-typedef int fexcept_t;
+#if defined(__x86_64__) || defined(__i386__)
+typedef unsigned short int fexcept_t;
+#else
+typedef unsigned int fexcept_t;
+#endif
#endif // LLVM_LIBC_TYPES_FEXCEPT_T_H
|
lntue
approved these changes
Oct 25, 2024
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
In glibc and musl, fexcept_t is unsigned short int on x86 and unsigned int on other machines that llvm-libc supports. Match that ABI (only different from before on x86) and API (different everywhere as it was previously signed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In glibc and musl, fexcept_t is unsigned short int on x86 and
unsigned int on other machines that llvm-libc supports. Match
that ABI (only different from before on x86) and API (different
everywhere as it was previously signed).