-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[RegAlloc] Scale the spill weight by target factor #113675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+4,186
−7,952
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2302,33 +2302,35 @@ define <vscale x 7 x i64> @vp_bitreverse_nxv7i64(<vscale x 7 x i64> %va, <vscale | |
; RV32-NEXT: vsll.vx v24, v24, a4, v0.t | ||
; RV32-NEXT: vor.vv v16, v16, v24, v0.t | ||
; RV32-NEXT: csrr a3, vlenb | ||
; RV32-NEXT: slli a3, a3, 4 | ||
; RV32-NEXT: slli a3, a3, 3 | ||
; RV32-NEXT: add a3, sp, a3 | ||
; RV32-NEXT: addi a3, a3, 16 | ||
; RV32-NEXT: vs8r.v v16, (a3) # Unknown-size Folded Spill | ||
; RV32-NEXT: vlse64.v v16, (a5), zero | ||
; RV32-NEXT: csrr a3, vlenb | ||
; RV32-NEXT: slli a3, a3, 3 | ||
; RV32-NEXT: slli a3, a3, 4 | ||
; RV32-NEXT: add a3, sp, a3 | ||
; RV32-NEXT: addi a3, a3, 16 | ||
; RV32-NEXT: vs8r.v v16, (a3) # Unknown-size Folded Spill | ||
; RV32-NEXT: lui a3, 4080 | ||
; RV32-NEXT: vand.vx v24, v8, a3, v0.t | ||
; RV32-NEXT: vsll.vi v24, v24, 24, v0.t | ||
; RV32-NEXT: addi a5, sp, 16 | ||
; RV32-NEXT: vs8r.v v24, (a5) # Unknown-size Folded Spill | ||
; RV32-NEXT: vand.vv v24, v8, v16, v0.t | ||
; RV32-NEXT: vsll.vi v16, v24, 8, v0.t | ||
; RV32-NEXT: vl8r.v v24, (a5) # Unknown-size Folded Reload | ||
; RV32-NEXT: vor.vv v16, v24, v16, v0.t | ||
; RV32-NEXT: vand.vx v16, v8, a3, v0.t | ||
; RV32-NEXT: vsll.vi v24, v16, 24, v0.t | ||
; RV32-NEXT: csrr a5, vlenb | ||
; RV32-NEXT: slli a5, a5, 4 | ||
; RV32-NEXT: add a5, sp, a5 | ||
; RV32-NEXT: addi a5, a5, 16 | ||
; RV32-NEXT: vl8r.v v16, (a5) # Unknown-size Folded Reload | ||
; RV32-NEXT: vand.vv v16, v8, v16, v0.t | ||
; RV32-NEXT: vsll.vi v16, v16, 8, v0.t | ||
; RV32-NEXT: vor.vv v16, v24, v16, v0.t | ||
; RV32-NEXT: csrr a5, vlenb | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be considered as a small regression because we have more reads of |
||
; RV32-NEXT: slli a5, a5, 3 | ||
; RV32-NEXT: add a5, sp, a5 | ||
; RV32-NEXT: addi a5, a5, 16 | ||
; RV32-NEXT: vl8r.v v24, (a5) # Unknown-size Folded Reload | ||
; RV32-NEXT: vor.vv v16, v24, v16, v0.t | ||
; RV32-NEXT: csrr a5, vlenb | ||
; RV32-NEXT: slli a5, a5, 4 | ||
; RV32-NEXT: slli a5, a5, 3 | ||
; RV32-NEXT: add a5, sp, a5 | ||
; RV32-NEXT: addi a5, a5, 16 | ||
; RV32-NEXT: vs8r.v v16, (a5) # Unknown-size Folded Spill | ||
|
@@ -2342,7 +2344,7 @@ define <vscale x 7 x i64> @vp_bitreverse_nxv7i64(<vscale x 7 x i64> %va, <vscale | |
; RV32-NEXT: vand.vx v24, v24, a3, v0.t | ||
; RV32-NEXT: vsrl.vi v8, v8, 8, v0.t | ||
; RV32-NEXT: csrr a1, vlenb | ||
; RV32-NEXT: slli a1, a1, 3 | ||
; RV32-NEXT: slli a1, a1, 4 | ||
; RV32-NEXT: add a1, sp, a1 | ||
; RV32-NEXT: addi a1, a1, 16 | ||
; RV32-NEXT: vl8r.v v16, (a1) # Unknown-size Folded Reload | ||
|
@@ -2360,7 +2362,7 @@ define <vscale x 7 x i64> @vp_bitreverse_nxv7i64(<vscale x 7 x i64> %va, <vscale | |
; RV32-NEXT: vsetvli a4, zero, e32, m8, ta, ma | ||
; RV32-NEXT: vmv.v.x v24, a1 | ||
; RV32-NEXT: csrr a1, vlenb | ||
; RV32-NEXT: slli a1, a1, 4 | ||
; RV32-NEXT: slli a1, a1, 3 | ||
; RV32-NEXT: add a1, sp, a1 | ||
; RV32-NEXT: addi a1, a1, 16 | ||
; RV32-NEXT: vl8r.v v16, (a1) # Unknown-size Folded Reload | ||
|
@@ -2687,33 +2689,35 @@ define <vscale x 8 x i64> @vp_bitreverse_nxv8i64(<vscale x 8 x i64> %va, <vscale | |
; RV32-NEXT: vsll.vx v24, v24, a4, v0.t | ||
; RV32-NEXT: vor.vv v16, v16, v24, v0.t | ||
; RV32-NEXT: csrr a3, vlenb | ||
; RV32-NEXT: slli a3, a3, 4 | ||
; RV32-NEXT: slli a3, a3, 3 | ||
; RV32-NEXT: add a3, sp, a3 | ||
; RV32-NEXT: addi a3, a3, 16 | ||
; RV32-NEXT: vs8r.v v16, (a3) # Unknown-size Folded Spill | ||
; RV32-NEXT: vlse64.v v16, (a5), zero | ||
; RV32-NEXT: csrr a3, vlenb | ||
; RV32-NEXT: slli a3, a3, 3 | ||
; RV32-NEXT: slli a3, a3, 4 | ||
; RV32-NEXT: add a3, sp, a3 | ||
; RV32-NEXT: addi a3, a3, 16 | ||
; RV32-NEXT: vs8r.v v16, (a3) # Unknown-size Folded Spill | ||
; RV32-NEXT: lui a3, 4080 | ||
; RV32-NEXT: vand.vx v24, v8, a3, v0.t | ||
; RV32-NEXT: vsll.vi v24, v24, 24, v0.t | ||
; RV32-NEXT: addi a5, sp, 16 | ||
; RV32-NEXT: vs8r.v v24, (a5) # Unknown-size Folded Spill | ||
; RV32-NEXT: vand.vv v24, v8, v16, v0.t | ||
; RV32-NEXT: vsll.vi v16, v24, 8, v0.t | ||
; RV32-NEXT: vl8r.v v24, (a5) # Unknown-size Folded Reload | ||
; RV32-NEXT: vor.vv v16, v24, v16, v0.t | ||
; RV32-NEXT: vand.vx v16, v8, a3, v0.t | ||
; RV32-NEXT: vsll.vi v24, v16, 24, v0.t | ||
; RV32-NEXT: csrr a5, vlenb | ||
; RV32-NEXT: slli a5, a5, 4 | ||
; RV32-NEXT: add a5, sp, a5 | ||
; RV32-NEXT: addi a5, a5, 16 | ||
; RV32-NEXT: vl8r.v v16, (a5) # Unknown-size Folded Reload | ||
; RV32-NEXT: vand.vv v16, v8, v16, v0.t | ||
; RV32-NEXT: vsll.vi v16, v16, 8, v0.t | ||
; RV32-NEXT: vor.vv v16, v24, v16, v0.t | ||
; RV32-NEXT: csrr a5, vlenb | ||
; RV32-NEXT: slli a5, a5, 3 | ||
; RV32-NEXT: add a5, sp, a5 | ||
; RV32-NEXT: addi a5, a5, 16 | ||
; RV32-NEXT: vl8r.v v24, (a5) # Unknown-size Folded Reload | ||
; RV32-NEXT: vor.vv v16, v24, v16, v0.t | ||
; RV32-NEXT: csrr a5, vlenb | ||
; RV32-NEXT: slli a5, a5, 4 | ||
; RV32-NEXT: slli a5, a5, 3 | ||
; RV32-NEXT: add a5, sp, a5 | ||
; RV32-NEXT: addi a5, a5, 16 | ||
; RV32-NEXT: vs8r.v v16, (a5) # Unknown-size Folded Spill | ||
|
@@ -2727,7 +2731,7 @@ define <vscale x 8 x i64> @vp_bitreverse_nxv8i64(<vscale x 8 x i64> %va, <vscale | |
; RV32-NEXT: vand.vx v24, v24, a3, v0.t | ||
; RV32-NEXT: vsrl.vi v8, v8, 8, v0.t | ||
; RV32-NEXT: csrr a1, vlenb | ||
; RV32-NEXT: slli a1, a1, 3 | ||
; RV32-NEXT: slli a1, a1, 4 | ||
; RV32-NEXT: add a1, sp, a1 | ||
; RV32-NEXT: addi a1, a1, 16 | ||
; RV32-NEXT: vl8r.v v16, (a1) # Unknown-size Folded Reload | ||
|
@@ -2745,7 +2749,7 @@ define <vscale x 8 x i64> @vp_bitreverse_nxv8i64(<vscale x 8 x i64> %va, <vscale | |
; RV32-NEXT: vsetvli a4, zero, e32, m8, ta, ma | ||
; RV32-NEXT: vmv.v.x v24, a1 | ||
; RV32-NEXT: csrr a1, vlenb | ||
; RV32-NEXT: slli a1, a1, 4 | ||
; RV32-NEXT: slli a1, a1, 3 | ||
; RV32-NEXT: add a1, sp, a1 | ||
; RV32-NEXT: addi a1, a1, 16 | ||
; RV32-NEXT: vl8r.v v16, (a1) # Unknown-size Folded Reload | ||
|
@@ -3052,19 +3056,8 @@ declare <vscale x 64 x i16> @llvm.vp.bitreverse.nxv64i16(<vscale x 64 x i16>, <v | |
define <vscale x 64 x i16> @vp_bitreverse_nxv64i16(<vscale x 64 x i16> %va, <vscale x 64 x i1> %m, i32 zeroext %evl) { | ||
; CHECK-LABEL: vp_bitreverse_nxv64i16: | ||
; CHECK: # %bb.0: | ||
; CHECK-NEXT: addi sp, sp, -16 | ||
; CHECK-NEXT: .cfi_def_cfa_offset 16 | ||
; CHECK-NEXT: csrr a1, vlenb | ||
; CHECK-NEXT: slli a1, a1, 4 | ||
; CHECK-NEXT: sub sp, sp, a1 | ||
; CHECK-NEXT: .cfi_escape 0x0f, 0x0d, 0x72, 0x00, 0x11, 0x10, 0x22, 0x11, 0x10, 0x92, 0xa2, 0x38, 0x00, 0x1e, 0x22 # sp + 16 + 16 * vlenb | ||
; CHECK-NEXT: vsetvli a1, zero, e8, m1, ta, ma | ||
; CHECK-NEXT: vmv1r.v v24, v0 | ||
; CHECK-NEXT: csrr a1, vlenb | ||
; CHECK-NEXT: slli a1, a1, 3 | ||
; CHECK-NEXT: add a1, sp, a1 | ||
; CHECK-NEXT: addi a1, a1, 16 | ||
; CHECK-NEXT: vs8r.v v8, (a1) # Unknown-size Folded Spill | ||
; CHECK-NEXT: vmv1r.v v7, v0 | ||
; CHECK-NEXT: csrr a3, vlenb | ||
; CHECK-NEXT: lui a1, 1 | ||
; CHECK-NEXT: lui a2, 3 | ||
|
@@ -3080,63 +3073,48 @@ define <vscale x 64 x i16> @vp_bitreverse_nxv64i16(<vscale x 64 x i16> %va, <vsc | |
; CHECK-NEXT: addi a2, a2, 819 | ||
; CHECK-NEXT: addi a1, a6, 1365 | ||
; CHECK-NEXT: vsetvli zero, a5, e16, m8, ta, ma | ||
; CHECK-NEXT: vsrl.vi v8, v16, 8, v0.t | ||
; CHECK-NEXT: vsrl.vi v24, v16, 8, v0.t | ||
; CHECK-NEXT: vsll.vi v16, v16, 8, v0.t | ||
; CHECK-NEXT: vor.vv v8, v16, v8, v0.t | ||
; CHECK-NEXT: vsrl.vi v16, v8, 4, v0.t | ||
; CHECK-NEXT: vor.vv v16, v16, v24, v0.t | ||
; CHECK-NEXT: vsrl.vi v24, v16, 4, v0.t | ||
; CHECK-NEXT: vand.vx v24, v24, a4, v0.t | ||
; CHECK-NEXT: vand.vx v16, v16, a4, v0.t | ||
; CHECK-NEXT: vand.vx v8, v8, a4, v0.t | ||
; CHECK-NEXT: vsll.vi v8, v8, 4, v0.t | ||
; CHECK-NEXT: vor.vv v8, v16, v8, v0.t | ||
; CHECK-NEXT: vsrl.vi v16, v8, 2, v0.t | ||
; CHECK-NEXT: vsll.vi v16, v16, 4, v0.t | ||
; CHECK-NEXT: vor.vv v16, v24, v16, v0.t | ||
; CHECK-NEXT: vsrl.vi v24, v16, 2, v0.t | ||
; CHECK-NEXT: vand.vx v24, v24, a2, v0.t | ||
; CHECK-NEXT: vand.vx v16, v16, a2, v0.t | ||
; CHECK-NEXT: vand.vx v8, v8, a2, v0.t | ||
; CHECK-NEXT: vsll.vi v8, v8, 2, v0.t | ||
; CHECK-NEXT: vor.vv v8, v16, v8, v0.t | ||
; CHECK-NEXT: vsrl.vi v16, v8, 1, v0.t | ||
; CHECK-NEXT: vsll.vi v16, v16, 2, v0.t | ||
; CHECK-NEXT: vor.vv v16, v24, v16, v0.t | ||
; CHECK-NEXT: vsrl.vi v24, v16, 1, v0.t | ||
; CHECK-NEXT: vand.vx v24, v24, a1, v0.t | ||
; CHECK-NEXT: vand.vx v16, v16, a1, v0.t | ||
; CHECK-NEXT: vand.vx v8, v8, a1, v0.t | ||
; CHECK-NEXT: vsll.vi v8, v8, 1, v0.t | ||
; CHECK-NEXT: vor.vv v8, v16, v8, v0.t | ||
; CHECK-NEXT: addi a5, sp, 16 | ||
; CHECK-NEXT: vs8r.v v8, (a5) # Unknown-size Folded Spill | ||
; CHECK-NEXT: vsll.vi v16, v16, 1, v0.t | ||
; CHECK-NEXT: vor.vv v16, v24, v16, v0.t | ||
; CHECK-NEXT: bltu a0, a3, .LBB46_2 | ||
; CHECK-NEXT: # %bb.1: | ||
; CHECK-NEXT: mv a0, a3 | ||
; CHECK-NEXT: .LBB46_2: | ||
; CHECK-NEXT: vmv1r.v v0, v24 | ||
; CHECK-NEXT: csrr a3, vlenb | ||
; CHECK-NEXT: slli a3, a3, 3 | ||
; CHECK-NEXT: add a3, sp, a3 | ||
; CHECK-NEXT: addi a3, a3, 16 | ||
; CHECK-NEXT: vl8r.v v8, (a3) # Unknown-size Folded Reload | ||
; CHECK-NEXT: vmv1r.v v0, v7 | ||
; CHECK-NEXT: vsetvli zero, a0, e16, m8, ta, ma | ||
; CHECK-NEXT: vsrl.vi v16, v8, 8, v0.t | ||
; CHECK-NEXT: vsrl.vi v24, v8, 8, v0.t | ||
; CHECK-NEXT: vsll.vi v8, v8, 8, v0.t | ||
; CHECK-NEXT: vor.vv v8, v8, v16, v0.t | ||
; CHECK-NEXT: vsrl.vi v16, v8, 4, v0.t | ||
; CHECK-NEXT: vand.vx v16, v16, a4, v0.t | ||
; CHECK-NEXT: vor.vv v8, v8, v24, v0.t | ||
; CHECK-NEXT: vsrl.vi v24, v8, 4, v0.t | ||
; CHECK-NEXT: vand.vx v24, v24, a4, v0.t | ||
; CHECK-NEXT: vand.vx v8, v8, a4, v0.t | ||
; CHECK-NEXT: vsll.vi v8, v8, 4, v0.t | ||
; CHECK-NEXT: vor.vv v8, v16, v8, v0.t | ||
; CHECK-NEXT: vsrl.vi v16, v8, 2, v0.t | ||
; CHECK-NEXT: vand.vx v16, v16, a2, v0.t | ||
; CHECK-NEXT: vor.vv v8, v24, v8, v0.t | ||
; CHECK-NEXT: vsrl.vi v24, v8, 2, v0.t | ||
; CHECK-NEXT: vand.vx v24, v24, a2, v0.t | ||
; CHECK-NEXT: vand.vx v8, v8, a2, v0.t | ||
; CHECK-NEXT: vsll.vi v8, v8, 2, v0.t | ||
; CHECK-NEXT: vor.vv v8, v16, v8, v0.t | ||
; CHECK-NEXT: vsrl.vi v16, v8, 1, v0.t | ||
; CHECK-NEXT: vand.vx v16, v16, a1, v0.t | ||
; CHECK-NEXT: vor.vv v8, v24, v8, v0.t | ||
; CHECK-NEXT: vsrl.vi v24, v8, 1, v0.t | ||
; CHECK-NEXT: vand.vx v24, v24, a1, v0.t | ||
; CHECK-NEXT: vand.vx v8, v8, a1, v0.t | ||
; CHECK-NEXT: vsll.vi v8, v8, 1, v0.t | ||
; CHECK-NEXT: vor.vv v8, v16, v8, v0.t | ||
; CHECK-NEXT: addi a0, sp, 16 | ||
; CHECK-NEXT: vl8r.v v16, (a0) # Unknown-size Folded Reload | ||
; CHECK-NEXT: csrr a0, vlenb | ||
; CHECK-NEXT: slli a0, a0, 4 | ||
; CHECK-NEXT: add sp, sp, a0 | ||
; CHECK-NEXT: .cfi_def_cfa sp, 16 | ||
; CHECK-NEXT: addi sp, sp, 16 | ||
; CHECK-NEXT: .cfi_def_cfa_offset 0 | ||
; CHECK-NEXT: vor.vv v8, v24, v8, v0.t | ||
; CHECK-NEXT: ret | ||
; | ||
; CHECK-ZVBB-LABEL: vp_bitreverse_nxv64i16: | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.