Skip to content

[llvm][SystemZ] Remove some leftover code from #106014. NFC. #113761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

alexrp
Copy link
Member

@alexrp alexrp commented Oct 26, 2024

Pointed out by @redstar here: https://github.com/llvm/llvm-project/pull/106014/files#r1816845388

Note: I don't have commit access.

@llvmbot
Copy link
Member

llvmbot commented Oct 26, 2024

@llvm/pr-subscribers-backend-systemz

Author: Alex Rønne Petersen (alexrp)

Changes

Pointed out by @redstar here: https://github.com/llvm/llvm-project/pull/106014/files#r1816845388


Full diff: https://github.com/llvm/llvm-project/pull/113761.diff

1 Files Affected:

  • (modified) llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp (-5)
diff --git a/llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp b/llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp
index 8fbd05eab5f6ee..f2fa7e7c9f9fee 100644
--- a/llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp
@@ -1450,11 +1450,6 @@ void SystemZXPLINKFrameLowering::inlineStackProbe(
 }
 
 bool SystemZXPLINKFrameLowering::hasFPImpl(const MachineFunction &MF) const {
-  // Naked functions have no stack frame pushed, so we don't have a frame
-  // pointer.
-  if (MF.getFunction().hasFnAttribute(Attribute::Naked))
-    return false;
-
   return (MF.getFrameInfo().hasVarSizedObjects());
 }
 

Copy link
Member

@uweigand uweigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uweigand uweigand merged commit 0df70c2 into llvm:main Oct 26, 2024
10 checks passed
@alexrp alexrp deleted the llvm-naked-no-fp-2 branch October 26, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants