Skip to content

[RISCV] Fix typo in UserGuides.rst. NFC #113861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[RISCV] Fix typo in UserGuides.rst. NFC #113861

merged 1 commit into from
Oct 28, 2024

Conversation

4vtomat
Copy link
Member

@4vtomat 4vtomat commented Oct 28, 2024

No description provided.

@4vtomat 4vtomat changed the title [RISCV] Fix typo in UserGuides.rst [RISCV] Fix typo in UserGuides.rst. NFC Oct 28, 2024
Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@asb asb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do feel free to just directly commit simple fixes like this (and good catch!).

@4vtomat
Copy link
Member Author

4vtomat commented Oct 28, 2024

Do feel free to just directly commit simple fixes like this (and good catch!).

Do you mean commit without a PR?

@4vtomat 4vtomat merged commit f5d8a48 into llvm:main Oct 28, 2024
9 checks passed
@4vtomat 4vtomat deleted the fix_typo branch October 28, 2024 10:30
@asb
Copy link
Contributor

asb commented Oct 28, 2024

Do feel free to just directly commit simple fixes like this (and good catch!).

Do you mean commit without a PR?

Yes, this is allowed in cases like this per the code review policy https://llvm.org/docs/CodeReview.html#must-code-be-reviewed-prior-to-being-committed

NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants