Skip to content

[rtsan][asan] NFC Fix hyperlink to CMake doc #113931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

cjappl
Copy link
Contributor

@cjappl cjappl commented Oct 28, 2024

The links right now show up like:

Screenshot 2024-10-28 at 8 55 04 AM

(rtsan, asan)

This change fixes them to be more traditional blue hyperlinks:

Screenshot 2024-10-28 at 8 55 54 AM

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Oct 28, 2024
@llvmbot
Copy link
Member

llvmbot commented Oct 28, 2024

@llvm/pr-subscribers-clang

Author: Chris Apple (cjappl)

Changes

The links right now show up like:

<img width="449" alt="Screenshot 2024-10-28 at 8 55 04 AM" src="https://github.com/user-attachments/assets/9e6b3e1f-e78f-46cb-a9f7-8164b6233340">

(rtsan, asan)

This change fixes them to be more traditional blue hyperlinks:

<img width="446" alt="Screenshot 2024-10-28 at 8 55 54 AM" src="https://github.com/user-attachments/assets/653450aa-435b-49ad-9e4d-72c6f9bdd8fd">


Full diff: https://github.com/llvm/llvm-project/pull/113931.diff

2 Files Affected:

  • (modified) clang/docs/AddressSanitizer.rst (+1-1)
  • (modified) clang/docs/RealtimeSanitizer.rst (+1-1)
diff --git a/clang/docs/AddressSanitizer.rst b/clang/docs/AddressSanitizer.rst
index 76fdf559950599..d937cbfdf583c4 100644
--- a/clang/docs/AddressSanitizer.rst
+++ b/clang/docs/AddressSanitizer.rst
@@ -26,7 +26,7 @@ Typical slowdown introduced by AddressSanitizer is **2x**.
 How to build
 ============
 
-Build LLVM/Clang with `CMake <https://llvm.org/docs/CMake.html>` and enable
+Build LLVM/Clang with `CMake <https://llvm.org/docs/CMake.html>`_ and enable
 the ``compiler-rt`` runtime. An example CMake configuration that will allow
 for the use/testing of AddressSanitizer:
 
diff --git a/clang/docs/RealtimeSanitizer.rst b/clang/docs/RealtimeSanitizer.rst
index 103842e055db70..f3f40b8bc3f5d5 100644
--- a/clang/docs/RealtimeSanitizer.rst
+++ b/clang/docs/RealtimeSanitizer.rst
@@ -21,7 +21,7 @@ The runtime slowdown introduced by RealtimeSanitizer is negligible.
 How to build
 ============
 
-Build LLVM/Clang with `CMake <https://llvm.org/docs/CMake.html>` and enable the
+Build LLVM/Clang with `CMake <https://llvm.org/docs/CMake.html>`_ and enable the
 ``compiler-rt`` runtime. An example CMake configuration that will allow for the
 use/testing of RealtimeSanitizer:
 

@cjappl cjappl merged commit ad5b944 into llvm:main Oct 28, 2024
11 checks passed
@cjappl cjappl deleted the fix_link_cmake branch October 28, 2024 19:25
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants