[debugserver] Mark ASAN memory regions as "heap" #113968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This memory type is currently not handled, but it makes sense to mark it as a heap allocation in requests asking for memory region info.
|
@llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) ChangesThis memory type is currently not handled, but it makes sense to mark it as a heap allocation in requests asking for memory region info. Full diff: https://github.com/llvm/llvm-project/pull/113968.diff 1 Files Affected:
diff --git a/lldb/tools/debugserver/source/MacOSX/MachVMRegion.cpp b/lldb/tools/debugserver/source/MacOSX/MachVMRegion.cpp
index 60d4c3bc293a3c..97908b4acaf284 100644
--- a/lldb/tools/debugserver/source/MacOSX/MachVMRegion.cpp
+++ b/lldb/tools/debugserver/source/MacOSX/MachVMRegion.cpp
@@ -208,7 +208,8 @@ std::vector<std::string> MachVMRegion::GetMemoryTypes() const {
m_data.user_tag == VM_MEMORY_MALLOC_LARGE_REUSABLE ||
m_data.user_tag == VM_MEMORY_MALLOC_HUGE ||
m_data.user_tag == VM_MEMORY_REALLOC ||
- m_data.user_tag == VM_MEMORY_SBRK) {
+ m_data.user_tag == VM_MEMORY_SBRK ||
+ m_data.user_tag == VM_MEMORY_SANITIZER) {
types.push_back("heap");
if (m_data.user_tag == VM_MEMORY_MALLOC_TINY) {
types.push_back("malloc-tiny");
|
felipepiovezan
added a commit
to felipepiovezan/llvm-project
that referenced
this pull request
Oct 28, 2024
This memory type is currently not handled, but it makes sense to mark it as a heap allocation in requests asking for memory region info. (cherry picked from commit 474234a)
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
This memory type is currently not handled, but it makes sense to mark it as a heap allocation in requests asking for memory region info.
felipepiovezan
added a commit
to felipepiovezan/llvm-project
that referenced
this pull request
Nov 19, 2024
The underlying issue was fixed in: llvm#113968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This memory type is currently not handled, but it makes sense to mark it as a heap allocation in requests asking for memory region info.