Skip to content

[NFC][CodeGen] Clang format MachineSink.cpp #114027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

optimisan
Copy link
Contributor

@optimisan optimisan commented Oct 29, 2024

Preparing to port this pass to new pass manager.

@optimisan
Copy link
Contributor Author

optimisan commented Oct 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@optimisan optimisan marked this pull request as ready for review October 29, 2024 10:28
@optimisan optimisan force-pushed the users/Akshat-Oke/10-29-_nfc_codegen_clang_format_machinesink.cpp branch from b67e6fc to dbedca0 Compare November 4, 2024 07:06
@optimisan optimisan force-pushed the users/Akshat-Oke/10-29-_nfc_codegen_clang_format_machinesink.cpp branch from dbedca0 to aeb7c60 Compare November 8, 2024 07:20
@optimisan optimisan force-pushed the users/Akshat-Oke/10-29-_nfc_codegen_clang_format_machinesink.cpp branch from aeb7c60 to c1661a9 Compare November 14, 2024 06:00
@optimisan optimisan force-pushed the users/Akshat-Oke/10-29-_nfc_codegen_clang_format_machinesink.cpp branch from c1661a9 to 071ad8e Compare November 14, 2024 11:53
@optimisan
Copy link
Contributor Author

optimisan commented Nov 14, 2024

Merge activity

  • Nov 14, 8:17 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 14, 8:18 AM EST: A user merged this pull request with Graphite.

@optimisan optimisan merged commit 43bef75 into main Nov 14, 2024
6 of 8 checks passed
@optimisan optimisan deleted the users/Akshat-Oke/10-29-_nfc_codegen_clang_format_machinesink.cpp branch November 14, 2024 13:18
@llvm-ci
Copy link
Collaborator

llvm-ci commented Nov 14, 2024

LLVM Buildbot has detected a new failure on builder llvm-clang-aarch64-darwin running on doug-worker-4 while building llvm at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/9476

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM :: ExecutionEngine/OrcLazy/multiple-compile-threads-basic.ll' FAILED ********************
Exit Code: 2

Command Output (stderr):
--
RUN: at line 1: /Users/buildbot/buildbot-root/aarch64-darwin/build/bin/lli -jit-kind=orc-lazy -compile-threads=2 -thread-entry hello /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/test/ExecutionEngine/OrcLazy/multiple-compile-threads-basic.ll | /Users/buildbot/buildbot-root/aarch64-darwin/build/bin/FileCheck /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/test/ExecutionEngine/OrcLazy/multiple-compile-threads-basic.ll
+ /Users/buildbot/buildbot-root/aarch64-darwin/build/bin/lli -jit-kind=orc-lazy -compile-threads=2 -thread-entry hello /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/test/ExecutionEngine/OrcLazy/multiple-compile-threads-basic.ll
+ /Users/buildbot/buildbot-root/aarch64-darwin/build/bin/FileCheck /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/test/ExecutionEngine/OrcLazy/multiple-compile-threads-basic.ll
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
 #0 0x0000000101e442d8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/Users/buildbot/buildbot-root/aarch64-darwin/build/bin/lli+0x100e702d8)
 #1 0x0000000101e4235c llvm::sys::RunSignalHandlers() (/Users/buildbot/buildbot-root/aarch64-darwin/build/bin/lli+0x100e6e35c)
 #2 0x0000000101e44994 SignalHandler(int) (/Users/buildbot/buildbot-root/aarch64-darwin/build/bin/lli+0x100e70994)
 #3 0x000000018354a584 (/usr/lib/system/libsystem_platform.dylib+0x18047a584)
 #4 0x000000018351921c (/usr/lib/system/libsystem_pthread.dylib+0x18044921c)
 #5 0x000000018343fad0 (/usr/lib/libc++.1.dylib+0x18036fad0)
 #6 0x0000000101a07454 void llvm::detail::UniqueFunctionBase<void, llvm::Expected<llvm::DenseMap<llvm::orc::SymbolStringPtr, llvm::orc::ExecutorSymbolDef, llvm::DenseMapInfo<llvm::orc::SymbolStringPtr, void>, llvm::detail::DenseMapPair<llvm::orc::SymbolStringPtr, llvm::orc::ExecutorSymbolDef>>>>::CallImpl<llvm::orc::Platform::lookupInitSymbols(llvm::orc::ExecutionSession&, llvm::DenseMap<llvm::orc::JITDylib*, llvm::orc::SymbolLookupSet, llvm::DenseMapInfo<llvm::orc::JITDylib*, void>, llvm::detail::DenseMapPair<llvm::orc::JITDylib*, llvm::orc::SymbolLookupSet>> const&)::$_44>(void*, llvm::Expected<llvm::DenseMap<llvm::orc::SymbolStringPtr, llvm::orc::ExecutorSymbolDef, llvm::DenseMapInfo<llvm::orc::SymbolStringPtr, void>, llvm::detail::DenseMapPair<llvm::orc::SymbolStringPtr, llvm::orc::ExecutorSymbolDef>>>&) (/Users/buildbot/buildbot-root/aarch64-darwin/build/bin/lli+0x100a33454)
 #7 0x0000000101a02c08 llvm::orc::AsynchronousSymbolQuery::handleComplete(llvm::orc::ExecutionSession&)::RunQueryCompleteTask::run() (/Users/buildbot/buildbot-root/aarch64-darwin/build/bin/lli+0x100a2ec08)
 #8 0x0000000101ab19c0 void* std::__1::__thread_proxy[abi:un170006]<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, llvm::orc::DynamicThreadPoolTaskDispatcher::dispatch(std::__1::unique_ptr<llvm::orc::Task, std::__1::default_delete<llvm::orc::Task>>)::$_0>>(void*) (/Users/buildbot/buildbot-root/aarch64-darwin/build/bin/lli+0x100add9c0)
 #9 0x0000000183519f94 (/usr/lib/system/libsystem_pthread.dylib+0x180449f94)
#10 0x0000000183514d34 (/usr/lib/system/libsystem_pthread.dylib+0x180444d34)
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /Users/buildbot/buildbot-root/aarch64-darwin/build/bin/FileCheck /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/test/ExecutionEngine/OrcLazy/multiple-compile-threads-basic.ll

--

********************


@optimisan
Copy link
Contributor Author

Thought I had a wrong conflict resolve, but doesn't seem like this should cause it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants