[mlir][NFC] Avoid a warning

[pfusik]

warning: template-id not allowed for destructor in C++20 [-Wtemplate-id-cdtor]

[llvmbot]

@llvm/pr-subscribers-mlir-core

@llvm/pr-subscribers-mlir

Author: Piotr Fusik (pfusik)

Changes

warning: template-id not allowed for destructor in C++20 [-Wtemplate-id-cdtor]

---

Full diff: https://github.com/llvm/llvm-project/pull/114052.diff

1 Files Affected:

• (modified) mlir/lib/Pass/PassRegistry.cpp (+1-1)

diff --git a/mlir/lib/Pass/PassRegistry.cpp b/mlir/lib/Pass/PassRegistry.cpp
index fe842755958418..029512fd3ecc11 100644
--- a/mlir/lib/Pass/PassRegistry.cpp
+++ b/mlir/lib/Pass/PassRegistry.cpp
@@ -422,7 +422,7 @@ llvm::cl::OptionValue<OpPassManager>::operator=(
   return *this;
 }
 
-llvm::cl::OptionValue<OpPassManager>::~OptionValue<OpPassManager>() = default;
+llvm::cl::OptionValue<OpPassManager>::~OptionValue() = default;
 
 void llvm::cl::OptionValue<OpPassManager>::setValue(
     const OpPassManager &newValue) {

[banach-space]

LGTM, thanks for the fix and for preparing the codebase for a transition to C++20 :)

[nit] Add a note saying which compiler makes this a warning (gcc? clang? and version)

[pfusik]

LGTM, thanks for the fix and for preparing the codebase for a transition to C++20 :)

[nit] Add a note saying which compiler makes this a warning (gcc? clang? and version)

Added in the commit message. gcc 14.1 and 14.2 emit this warning even without -std=c++20: https://godbolt.org/z/r4P7rqEb7

[joker-eph]

Thanks for the fix!