Skip to content

[RISCV] Add sha and supm to checks in riscv-profiles.c #114123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Oct 29, 2024

No description provided.

@topperc topperc requested review from asb and wangpc-pp October 29, 2024 20:25
@llvmbot llvmbot added clang Clang issues not falling into any other category backend:RISC-V clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Oct 29, 2024
@llvmbot
Copy link
Member

llvmbot commented Oct 29, 2024

@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-backend-risc-v

Author: Craig Topper (topperc)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/114123.diff

1 Files Affected:

  • (modified) clang/test/Driver/riscv-profiles.c (+3)
diff --git a/clang/test/Driver/riscv-profiles.c b/clang/test/Driver/riscv-profiles.c
index 2b4d19422874cf..67e09d0e69ebc3 100644
--- a/clang/test/Driver/riscv-profiles.c
+++ b/clang/test/Driver/riscv-profiles.c
@@ -147,6 +147,7 @@
 // RVA23U64: "-target-feature" "+zvbb"
 // RVA23U64: "-target-feature" "+zvfhmin"
 // RVA23U64: "-target-feature" "+zvkt"
+// RVA23U64: "-target-feature" "+supm"
 
 // RUN: %clang --target=riscv64 -### -c %s 2>&1 -march=rva23s64 \
 // RUN:   | FileCheck -check-prefix=RVA23S64 %s
@@ -186,6 +187,7 @@
 // RVA23S64: "-target-feature" "+zvbb"
 // RVA23S64: "-target-feature" "+zvfhmin"
 // RVA23S64: "-target-feature" "+zvkt"
+// RVA23S64: "-target-feature" "+sha"
 // RVA23S64: "-target-feature" "+shcounterenw"
 // RVA23S64: "-target-feature" "+shgatpa"
 // RVA23S64: "-target-feature" "+shtvala"
@@ -201,6 +203,7 @@
 // RVA23S64: "-target-feature" "+sstvala"
 // RVA23S64: "-target-feature" "+sstvecd"
 // RVA23S64: "-target-feature" "+ssu64xl"
+// RVA23S64: "-target-feature" "+supm"
 // RVA23S64: "-target-feature" "+svade"
 // RVA23S64: "-target-feature" "+svbare"
 // RVA23S64: "-target-feature" "+svinval"

Copy link
Contributor

@asb asb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@topperc topperc merged commit d926828 into llvm:main Oct 30, 2024
10 of 12 checks passed
@topperc topperc deleted the pr/profiles-tests branch October 30, 2024 01:08
@llvm-ci
Copy link
Collaborator

llvm-ci commented Oct 30, 2024

LLVM Buildbot has detected a new failure on builder llvm-clang-x86_64-darwin running on doug-worker-3 while building clang at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/4284

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'cross-project-tests :: debuginfo-tests/llgdb-tests/nrvo-string.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
Running debugger
Running FileCheck
Running debugger
Debugger output was:
imported lldb from: "/Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Resources/Python"
>  break 23
SBBreakpoint: id = 1, file = '/Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/nrvo-string.cpp', line = 23, exact_match = 0, locations = 1
>  break 39
SBBreakpoint: id = 2, file = '/Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/nrvo-string.cpp', line = 39, exact_match = 0, locations = 1
>  r
success
>  print result.i
(int) $0 = 3
>  c
None
>  print result.i
(int) $1 = 5
> quit
Process 50043 resuming
Process 50043 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 2.1
    frame #0: 0x0000000100000f10 nrvo-string.cpp.tmp.out`get_string2() at nrvo-string.cpp:39:3
   36  	  // Test that the debugger can get the value of result after another
   37  	  // function is called.
   38  	  // DEBUGGER: break 39
-> 39  	  stop();
    	  ^
   40  	  return result;
   41  	}
   42  	int main() {
Target 0: (nrvo-string.cpp.tmp.out) stopped.

--
Command Output (stderr):
--
RUN: at line 4: /Users/buildbot/buildbot-root/x86_64-darwin/build/bin/clang --driver-mode=g++ -O0 -fno-exceptions --target=x86_64-apple-darwin23.6.0 /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/nrvo-string.cpp -o /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out -g
+ /Users/buildbot/buildbot-root/x86_64-darwin/build/bin/clang --driver-mode=g++ -O0 -fno-exceptions --target=x86_64-apple-darwin23.6.0 /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/nrvo-string.cpp -o /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out -g
RUN: at line 5: /Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/test_debuginfo.pl /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/nrvo-string.cpp /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out
+ /Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/test_debuginfo.pl /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/nrvo-string.cpp /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out
RUN: at line 6: /Users/buildbot/buildbot-root/x86_64-darwin/build/bin/clang --driver-mode=g++ -O1 -fno-exceptions --target=x86_64-apple-darwin23.6.0 /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/nrvo-string.cpp -o /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out -g
+ /Users/buildbot/buildbot-root/x86_64-darwin/build/bin/clang --driver-mode=g++ -O1 -fno-exceptions --target=x86_64-apple-darwin23.6.0 /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/nrvo-string.cpp -o /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out -g
RUN: at line 7: /Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/test_debuginfo.pl /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/nrvo-string.cpp /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out
+ /Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/test_debuginfo.pl /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/cross-project-tests/debuginfo-tests/llgdb-tests/nrvo-string.cpp /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out

--
...

NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:RISC-V clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants