[NFC] Call base class method in DarwinAArch64TargetInfo::getOSDefines #114241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-clang Author: Akira Hatanaka (ahatanak) ChangesFull diff: https://github.com/llvm/llvm-project/pull/114241.diff 1 Files Affected:
diff --git a/clang/lib/Basic/Targets/AArch64.cpp b/clang/lib/Basic/Targets/AArch64.cpp
index a0f94d5d315480..e9c1917ccbf060 100644
--- a/clang/lib/Basic/Targets/AArch64.cpp
+++ b/clang/lib/Basic/Targets/AArch64.cpp
@@ -1716,7 +1716,7 @@ void DarwinAArch64TargetInfo::getOSDefines(const LangOptions &Opts,
if (Triple.isArm64e())
Builder.defineMacro("__arm64e__", "1");
- getDarwinDefines(Builder, Opts, Triple, PlatformName, PlatformMinVersion);
+ DarwinTargetInfo<AArch64leTargetInfo>::getOSDefines(Opts, Triple, Builder);
}
TargetInfo::BuiltinVaListKind
|
ahatanak
force-pushed
the
call-base-method
branch
from
606344e to
98fe161
Compare
|
What's the motivation for this change? |
ahatanak
changed the title
|
This is needed for a private patch we'll be upstreaming in the future. Even without that, I think it's an improvement over what we are doing now. |
smallp-o-p
pushed a commit
to smallp-o-p/llvm-project
that referenced
this pull request
Nov 3, 2024
…llvm#114241) This is needed for a private patch we'll be upstreaming in the future.
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
…llvm#114241) This is needed for a private patch we'll be upstreaming in the future.
ahatanaka
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Nov 7, 2024
…llvm#114241) This is needed for a private patch we'll be upstreaming in the future. rdar://138459863
ahatanaka
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Nov 7, 2024
…llvm#114241) This is needed for a private patch we'll be upstreaming in the future. rdar://138459863
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.