Skip to content

[InlineCost] Print inline cost for invoke call sites as well #114476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions llvm/lib/Analysis/InlineCost.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3257,16 +3257,16 @@ InlineCostAnnotationPrinterPass::run(Function &F,
const InlineParams Params = llvm::getInlineParams();
for (BasicBlock &BB : F) {
for (Instruction &I : BB) {
if (CallInst *CI = dyn_cast<CallInst>(&I)) {
Function *CalledFunction = CI->getCalledFunction();
if (auto *CB = dyn_cast<CallBase>(&I)) {
Function *CalledFunction = CB->getCalledFunction();
if (!CalledFunction || CalledFunction->isDeclaration())
continue;
OptimizationRemarkEmitter ORE(CalledFunction);
InlineCostCallAnalyzer ICCA(*CalledFunction, *CI, Params, TTI,
InlineCostCallAnalyzer ICCA(*CalledFunction, *CB, Params, TTI,
GetAssumptionCache, nullptr, &PSI, &ORE);
ICCA.analyze();
OS << " Analyzing call of " << CalledFunction->getName()
<< "... (caller:" << CI->getCaller()->getName() << ")\n";
<< "... (caller:" << CB->getCaller()->getName() << ")\n";
ICCA.print(OS);
OS << "\n";
}
Expand Down
31 changes: 31 additions & 0 deletions llvm/test/Transforms/Inline/inline-cost-annotation-pass.ll
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,34 @@ define ptr @main() {
%2 = call ptr @foo()
ret ptr %1
}

; Make sure it also analyzes invoke call sites.

; CHECK: Analyzing call of g... (caller:f)
; CHECK: define i32 @g(i32 %v) {
; CHECK: ; cost before = {{.*}}, cost after = {{.*}}, threshold before = {{.*}}, threshold after = {{.*}}, cost delta = {{.*}}
; CHECK: %p = icmp ugt i32 %v, 35
; CHECK: ; cost before = {{.*}}, cost after = {{.*}}, threshold before = {{.*}}, threshold after = {{.*}}, cost delta = {{.*}}
; CHECK: %r = select i1 %p, i32 %v, i32 7
; CHECK: ; cost before = {{.*}}, cost after = {{.*}}, threshold before = {{.*}}, threshold after = {{.*}}, cost delta = {{.*}}
; CHECK: ret i32 %r
; CHECK: }
define i32 @g(i32 %v) {
%p = icmp ugt i32 %v, 35
%r = select i1 %p, i32 %v, i32 7
ret i32 %r
}

define void @f(i32 %v, ptr %dst) personality ptr @__gxx_personality_v0 {
%v1 = invoke i32 @g(i32 %v)
to label %bb1 unwind label %bb2
bb1:
store i32 %v1, ptr %dst
ret void
bb2:
%lpad.loopexit80 = landingpad { ptr, i32 }
cleanup
ret void
}

declare i32 @__gxx_personality_v0(...)
Loading