[libc][newhdrgen] Fix NameError in yaml_to_classes.py

[overmighty]

Fixes "NameError: name 'yaml_file' is not defined" that would be raised
whenever running yaml_to_classes.py with the --add_function option since
commit 2e6d451.

[llvmbot]

@llvm/pr-subscribers-libc

Author: OverMighty (overmighty)

Changes

Fixes "NameError: name 'yaml_file' is not defined" that would be raised
whenever running yaml_to_classes.py with the --add_function option since
commit 2e6d451.

---

Full diff: https://github.com/llvm/llvm-project/pull/114952.diff

1 Files Affected:

• (modified) libc/newhdrgen/yaml_to_classes.py (+1-1)

diff --git a/libc/newhdrgen/yaml_to_classes.py b/libc/newhdrgen/yaml_to_classes.py
index a295058f7dc821..0e8ca2d8a82b0c 100644
--- a/libc/newhdrgen/yaml_to_classes.py
+++ b/libc/newhdrgen/yaml_to_classes.py
@@ -253,7 +253,7 @@ def main():
     args = parser.parse_args()
 
     if args.add_function:
-        add_function_to_yaml(yaml_file, args.add_function)
+        add_function_to_yaml(args.yaml_file, args.add_function)
 
     header_class = GpuHeader if args.export_decls else HeaderFile
     header = load_yaml_file(args.yaml_file, header_class, args.entry_points)

[kh3rld]

This change fixes the NameError: name 'yaml_file' is not defined in yaml_to_classes.py when the --add_function option is used. The issue, introduced in commit 2e6d451, is resolved by correctly passing args.yaml_file to the add_function_to_yaml function instead of the undefined yaml_file.

Full diff: PR Diff

File modified:

• libc/newhdrgen/yaml_to_classes.py (+1 -1)

[nickdesaulniers]

Thanks! We were just discussing how little used this feature was, so it's not surprising we didn't notice this breakage. We also discussed possibly separating out this particular feature into its own standalone command line util. Thanks for the patch, though!