Skip to content

[libc][bazel] Remove -mllvm --tail-merge-threshold=0 from Bazel. #115061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

vonosmas
Copy link
Contributor

@vonosmas vonosmas commented Nov 5, 2024

Follow-up on the -mllvm --tail-merge-threshold=0 removal promised in aeccc16 (see b2a9ea4 commit message on why we don't need this in Bazel, and will only keep in AArch64-specific compile flags in CMake build).

@vonosmas vonosmas requested a review from gchatelet November 5, 2024 20:31
@llvmbot llvmbot added libc bazel "Peripheral" support tier build system: utils/bazel labels Nov 5, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 5, 2024

@llvm/pr-subscribers-libc

Author: Alexey Samsonov (vonosmas)

Changes

Follow-up on the -mllvm --tail-merge-threshold=0 removal promised in aeccc16 (see b2a9ea4 commit message on why we don't need this in Bazel, and will only keep in AArch64-specific compile flags in CMake build).


Full diff: https://github.com/llvm/llvm-project/pull/115061.diff

1 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/BUILD.bazel (-2)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index f6648c9bffa730..54c1c3eb27f203 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -3648,7 +3648,6 @@ libc_function(
     name = "memcpy",
     srcs = ["src/string/memcpy.cpp"],
     hdrs = ["src/string/memcpy.h"],
-    copts = ["-mllvm --tail-merge-threshold=0"],
     features = no_sanitize_features,
     weak = True,
     deps = [
@@ -3685,7 +3684,6 @@ libc_function(
     name = "mempcpy",
     srcs = ["src/string/mempcpy.cpp"],
     hdrs = ["src/string/mempcpy.h"],
-    copts = ["-mllvm --tail-merge-threshold=0"],
     features = no_sanitize_features,
     weak = True,
     deps = [

@gchatelet gchatelet merged commit 2f48765 into llvm:main Nov 6, 2024
9 checks passed
@vonosmas vonosmas deleted the tail-merge-threshold branch November 6, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel libc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants