[libc] Add the src/stdlib/_Exit.h header to at_quick_exit_test.cpp and atexit_test.cpp
#115351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2024 09:44
|
@llvm/pr-subscribers-libc Author: Job Henandez Lara (Jobhdez) ChangesHello, I merged this #114904 a few mins ago and the tests failed because i did not add the header I ran both builds/tests and everything was good. thanks Full diff: https://github.com/llvm/llvm-project/pull/115351.diff 2 Files Affected:
diff --git a/libc/test/src/stdlib/at_quick_exit_test.cpp b/libc/test/src/stdlib/at_quick_exit_test.cpp
index 1ed5a83a61b8d0..c0aac4d20d92cc 100644
--- a/libc/test/src/stdlib/at_quick_exit_test.cpp
+++ b/libc/test/src/stdlib/at_quick_exit_test.cpp
@@ -8,6 +8,7 @@
#include "src/__support/CPP/array.h"
#include "src/__support/CPP/utility.h"
+#include "src/stdlib/_Exit.h"
#include "src/stdlib/at_quick_exit.h"
#include "src/stdlib/quick_exit.h"
#include "test/UnitTest/Test.h"
diff --git a/libc/test/src/stdlib/atexit_test.cpp b/libc/test/src/stdlib/atexit_test.cpp
index 24f8b0451f3636..c25202ff54f696 100644
--- a/libc/test/src/stdlib/atexit_test.cpp
+++ b/libc/test/src/stdlib/atexit_test.cpp
@@ -8,6 +8,7 @@
#include "src/__support/CPP/array.h"
#include "src/__support/CPP/utility.h"
+#include "src/stdlib/_Exit.h"
#include "src/stdlib/atexit.h"
#include "src/stdlib/exit.h"
#include "test/UnitTest/Test.h"
|
ghost
requested a review
from 
nickdesaulniers
approved these changes
Nov 7, 2024
michaelrj-google
approved these changes
Nov 7, 2024
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
…` and `atexit_test.cpp` (llvm#115351) Hello, I merged this llvm#114904 a few mins ago and the tests failed because i did not add the header `src/stdlib/_Exit.h` in `at_quick_exit_test.cpp` and `atexit_test.cpp`. I ran both builds/tests and everything was good. thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I merged this #114904 a few mins ago and the tests failed because i did not add the header
src/stdlib/_Exit.hinat_quick_exit_test.cppandatexit_test.cpp.I ran both builds/tests and everything was good. thanks