-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[CodeGen][NewPM] Port LiveDebugVariables to NPM #115468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
optimisan
merged 7 commits into
main
from
users/Akshat-Oke/11-08-_codegen_newpm_port_livedebugvariables_to_npm
Dec 4, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
172c6d6
[CodeGen][NewPM] Port LiveDebugVariables to NPM
optimisan 352f909
Use unique_ptr
optimisan bc70f89
Rename to Legacy, add printer and invalidate
optimisan 1ce5e29
Fix invalidate and expose LDVImpl to .h
optimisan 4943aef
Move LDVImpl to LiveDebugVariables
optimisan 7f35339
remove debugging printing
optimisan 0e9899f
Fix nullptr in releaseMemory and mfprops
optimisan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add
LiveDebugVariablesPrinterPass
,LDVImpl
hasprint
method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print methods are hidden behind
NDEBUG
, and are invoked inrunOnMachineFunction
.Is NPM moving away from printing debug info with DEBUG_TYPE?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see it.
DEBUG_TYPE
andLLVM_DEBUG
work in debug build and-debug-only
options, a printer pass should work anyway, we could keep theLLVM_DEBUG
inrunOnMachineFunction
as is and expose the hidden print method, if it doesn't call any API which is only available in debug mode.