Skip to content

[lldb] Fixed the @skipUnlessAArch64MTELinuxCompiler decorator #115480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

slydiman
Copy link
Contributor

@slydiman slydiman commented Nov 8, 2024

@llvmbot
Copy link
Member

llvmbot commented Nov 8, 2024

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

It is broken after #115337

https://lab.llvm.org/buildbot/#/builders/195/builds/794


Full diff: https://github.com/llvm/llvm-project/pull/115480.diff

1 Files Affected:

  • (modified) lldb/packages/Python/lldbsuite/test/decorators.py (+5-2)
diff --git a/lldb/packages/Python/lldbsuite/test/decorators.py b/lldb/packages/Python/lldbsuite/test/decorators.py
index 0bb9ab9f5f8929..c48c0b2f779449 100644
--- a/lldb/packages/Python/lldbsuite/test/decorators.py
+++ b/lldb/packages/Python/lldbsuite/test/decorators.py
@@ -997,7 +997,10 @@ def is_toolchain_with_mte():
         f.close()
 
         cmd = f"{compiler_path} -x c -o {f.name} -"
-        if subprocess.run(cmd, input="int main() {}".encode()).returncode != 0:
+        if (
+            subprocess.run(cmd, shell=True, input="int main() {}".encode()).returncode
+            != 0
+        ):
             os.remove(f.name)
             # Cannot compile at all, don't skip the test
             # so that we report the broken compiler normally.
@@ -1014,7 +1017,7 @@ def is_toolchain_with_mte():
                 void* ptr = __arm_mte_create_random_tag((void*)(0), 0);
             }"""
         cmd = f"{compiler_path} -march=armv8.5-a+memtag -x c -o {f.name} -"
-        res = subprocess.run(cmd, input=test_src.encode())
+        res = subprocess.run(cmd, shell=True, input=test_src.encode())
         os.remove(f.name)
         if res.returncode != 0:
             return "Toolchain does not support MTE"

@dzhidzhoev dzhidzhoev self-requested a review November 8, 2024 13:42
@slydiman slydiman merged commit 32c744a into llvm:main Nov 8, 2024
7 of 8 checks passed
@slydiman slydiman deleted the lldb-fix-skipUnlessAArch64MTELinuxCompiler-2 branch April 18, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants