Skip to content

[mlir][spirv] Add spirv-to-llvm conversion for group operations #115501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2024
Merged

[mlir][spirv] Add spirv-to-llvm conversion for group operations #115501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f938531
[mlir][spirv] Add spirv-to-llvm conversion for group operations
sommerlukas Nov 8, 2024
8f9fc62
Code formatting
sommerlukas Nov 8, 2024
2d97df0
Address PR feedback
sommerlukas Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
226 changes: 223 additions & 3 deletions mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include "mlir/IR/BuiltinOps.h"
#include "mlir/IR/PatternMatch.h"
#include "mlir/Transforms/DialectConversion.h"
#include "llvm/ADT/TypeSwitch.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/FormatVariadic.h"

Expand Down Expand Up @@ -1027,7 +1028,8 @@ class ReturnValuePattern : public SPIRVToLLVMConversion<spirv::ReturnValueOp> {
static LLVM::LLVMFuncOp lookupOrCreateSPIRVFn(Operation *symbolTable,
StringRef name,
ArrayRef<Type> paramTypes,
Type resultType) {
Type resultType,
bool convergent = true) {
auto func = dyn_cast_or_null<LLVM::LLVMFuncOp>(
SymbolTable::lookupSymbolIn(symbolTable, name));
if (func)
Expand All @@ -1038,7 +1040,7 @@ static LLVM::LLVMFuncOp lookupOrCreateSPIRVFn(Operation *symbolTable,
symbolTable->getLoc(), name,
LLVM::LLVMFunctionType::get(resultType, paramTypes));
func.setCConv(LLVM::cconv::CConv::SPIR_FUNC);
func.setConvergent(true);
func.setConvergent(convergent);
func.setNoUnwind(true);
func.setWillReturn(true);
return func;
Expand Down Expand Up @@ -1089,6 +1091,181 @@ class ControlBarrierPattern
}
};

namespace {

StringRef getTypeMangling(Type type, bool isSigned) {
return llvm::TypeSwitch<Type, StringRef>(type)
.Case<Float16Type>([](auto) { return "Dh"; })
.Case<Float32Type>([](auto) { return "f"; })
.Case<Float64Type>([](auto) { return "d"; })
.Case<IntegerType>([isSigned](IntegerType intTy) {
switch (intTy.getWidth()) {
case 1:
return "b";
case 8:
return (isSigned) ? "a" : "c";
case 16:
return (isSigned) ? "s" : "t";
case 32:
return (isSigned) ? "i" : "j";
case 64:
return (isSigned) ? "l" : "m";
default:
llvm_unreachable("Unsupported integer width");
}
})
.Default([](auto) {
llvm_unreachable("No mangling defined");
return "";
});
}

template <typename ReduceOp>
constexpr StringLiteral getGroupFuncName();

template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupIAddOp>() {
return "_Z17__spirv_GroupIAddii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupFAddOp>() {
return "_Z17__spirv_GroupFAddii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupSMinOp>() {
return "_Z17__spirv_GroupSMinii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupUMinOp>() {
return "_Z17__spirv_GroupUMinii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupFMinOp>() {
return "_Z17__spirv_GroupFMinii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupSMaxOp>() {
return "_Z17__spirv_GroupSMaxii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupUMaxOp>() {
return "_Z17__spirv_GroupUMaxii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupFMaxOp>() {
return "_Z17__spirv_GroupFMaxii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformIAddOp>() {
return "_Z27__spirv_GroupNonUniformIAddii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformFAddOp>() {
return "_Z27__spirv_GroupNonUniformFAddii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformIMulOp>() {
return "_Z27__spirv_GroupNonUniformIMulii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformFMulOp>() {
return "_Z27__spirv_GroupNonUniformFMulii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformSMinOp>() {
return "_Z27__spirv_GroupNonUniformSMinii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformUMinOp>() {
return "_Z27__spirv_GroupNonUniformUMinii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformFMinOp>() {
return "_Z27__spirv_GroupNonUniformFMinii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformSMaxOp>() {
return "_Z27__spirv_GroupNonUniformSMaxii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformUMaxOp>() {
return "_Z27__spirv_GroupNonUniformUMaxii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformFMaxOp>() {
return "_Z27__spirv_GroupNonUniformFMaxii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformBitwiseAndOp>() {
return "_Z33__spirv_GroupNonUniformBitwiseAndii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformBitwiseOrOp>() {
return "_Z32__spirv_GroupNonUniformBitwiseOrii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformBitwiseXorOp>() {
return "_Z33__spirv_GroupNonUniformBitwiseXorii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformLogicalAndOp>() {
return "_Z33__spirv_GroupNonUniformLogicalAndii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformLogicalOrOp>() {
return "_Z32__spirv_GroupNonUniformLogicalOrii";
}
template <>
constexpr StringLiteral getGroupFuncName<spirv::GroupNonUniformLogicalXorOp>() {
return "_Z33__spirv_GroupNonUniformLogicalXorii";
}
} // namespace

template <typename ReduceOp, bool Signed = false, bool NonUniform = false>
class GroupReducePattern : public SPIRVToLLVMConversion<ReduceOp> {
public:
using SPIRVToLLVMConversion<ReduceOp>::SPIRVToLLVMConversion;

LogicalResult
matchAndRewrite(ReduceOp op, typename ReduceOp::Adaptor adaptor,
ConversionPatternRewriter &rewriter) const override {

Type retTy = op.getResult().getType();
if (!retTy.isIntOrFloat()) {
return failure();
}
SmallString<36> funcName = getGroupFuncName<ReduceOp>();
funcName += getTypeMangling(retTy, false);

Type i32Ty = rewriter.getI32Type();
SmallVector<Type> paramTypes{i32Ty, i32Ty, retTy};
if constexpr (NonUniform) {
if (adaptor.getClusterSize()) {
funcName += "j";
paramTypes.push_back(i32Ty);
}
}

Operation *symbolTable =
op->template getParentWithTrait<OpTrait::SymbolTable>();

LLVM::LLVMFuncOp func = lookupOrCreateSPIRVFn(
symbolTable, funcName, paramTypes, retTy, !NonUniform);

Location loc = op.getLoc();
Value scope = rewriter.create<LLVM::ConstantOp>(
loc, i32Ty, static_cast<int32_t>(adaptor.getExecutionScope()));
Value groupOp = rewriter.create<LLVM::ConstantOp>(
loc, i32Ty, static_cast<int32_t>(adaptor.getGroupOperation()));
SmallVector<Value> operands{scope, groupOp};
operands.append(adaptor.getOperands().begin(), adaptor.getOperands().end());

auto call = createSPIRVBuiltinCall(loc, rewriter, func, operands);
rewriter.replaceOp(op, call);
return success();
}
};

/// Converts `spirv.mlir.loop` to LLVM dialect. All blocks within selection
/// should be reachable for conversion to succeed. The structure of the loop in
/// LLVM dialect will be the following:
Expand Down Expand Up @@ -1722,7 +1899,50 @@ void mlir::populateSPIRVToLLVMConversionPatterns(
ReturnPattern, ReturnValuePattern,

// Barrier ops
ControlBarrierPattern>(patterns.getContext(), typeConverter);
ControlBarrierPattern,

// Group reduction operations
GroupReducePattern<spirv::GroupIAddOp>,
GroupReducePattern<spirv::GroupFAddOp>,
GroupReducePattern<spirv::GroupFMinOp>,
GroupReducePattern<spirv::GroupUMinOp>,
GroupReducePattern<spirv::GroupSMinOp, /*Signed=*/true>,
GroupReducePattern<spirv::GroupFMaxOp>,
GroupReducePattern<spirv::GroupUMaxOp>,
GroupReducePattern<spirv::GroupSMaxOp, /*Signed=*/true>,
GroupReducePattern<spirv::GroupNonUniformIAddOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformFAddOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformIMulOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformFMulOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformSMinOp, /*Signed=*/true,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformUMinOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformFMinOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformSMaxOp, /*Signed=*/true,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformUMaxOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformFMaxOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformBitwiseAndOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformBitwiseOrOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformBitwiseXorOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformLogicalAndOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformLogicalOrOp, /*Signed=*/false,
/*NonUniform=*/true>,
GroupReducePattern<spirv::GroupNonUniformLogicalXorOp, /*Signed=*/false,
/*NonUniform=*/true>>(patterns.getContext(),
typeConverter);

patterns.add<GlobalVariablePattern>(clientAPI, patterns.getContext(),
typeConverter);
Expand Down
Loading
Loading