[Baze] Add missing lldbDataFormatter.py back to BUILD.bazel. #115519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorGray
reviewed
Nov 8, 2024
| @@ -32,6 +32,7 @@ exports_files([ | |||
| "include/llvm/IR/Intrinsics.td", | |||
| "include/llvm/Option/OptParser.td", | |||
| "utils/lit/lit.py", | |||
| "utils/lldbDataFormatters.py", | |||
There was a problem hiding this comment.
Suggestion Would it make sense to add a comment here confirming that this has usage by downstream users of LLVM?
For context for other reviewers, this was originally added a few months ago in b1a93db, but then removed a few days ago in bb9ff32 because it appeared unused within LLVM.
To hedge against a similar cleanup effort removing these in the future, a comment in the source confirming this has external usage might help.
There was a problem hiding this comment.
Yes, that was exactly my comment in #114620 (comment).
There was a problem hiding this comment.
Adding a comment here #115556
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
…5519) - [x] Add `utils/lldbDataFormatters.py` back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils/lldbDataFormatters.pyback.