CodeGen: Don't assert when printing null GlobalAddress operands

[arsenm]

No description provided.

[arsenm]

• CodeGen: Don't assert when printing null GlobalAddress operands #115531 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[qcolombet]

I'm guessing this is for mir files.
I ran into this problem in the past.

LGTM, but could you add a mir test and here add a comment that specifically says that this shouldn't be the state of a well formed ir. (Unless you're fixing a real bug, and then we are missing a test anyway)

[arsenm]

I'm guessing this is for mir files. I ran into this problem in the past.

LGTM, but could you add a mir test and here add a comment that specifically says that this shouldn't be the state of a well formed ir. (Unless you're fixing a real bug, and then we are missing a test anyway)

I don't think this can be constructed from MIR. A literal 0 won't parse as a GlobalAddress

[qcolombet]

I'm guessing this is for mir files. I ran into this problem in the past.
LGTM, but could you add a mir test and here add a comment that specifically says that this shouldn't be the state of a well formed ir. (Unless you're fixing a real bug, and then we are missing a test anyway)

I don't think this can be constructed from MIR. A literal 0 won't parse as a GlobalAddress

So how do you run into this problem?

It sounds to me that we shouldn't produce nullptr for GlobalAddress in a normal compilation flow.

[arsenm]

So how do you run into this problem?

Bugs

It sounds to me that we shouldn't produce nullptr for GlobalAddress in a normal compilation flow.

Yes, but this is in debug printing. -debug causing new crashes to appear is a bad property

[qcolombet]

So how do you run into this problem?

Bugs

It sounds to me that we shouldn't produce nullptr for GlobalAddress in a normal compilation flow.

Yes, but this is in debug printing. -debug causing new crashes to appear is a bad property

Fair enough.
Could you add a comment that says that this is for debug printing?