[NFC][mlir][emitc] fix misspelling in description of emitc.global

[EtoAndruwa]

Missing ! before emitc.global was added in the EmitC.td.

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Andrey Timonin (EtoAndruwa)

Changes

Missing ! before emitc.global was added in the EmitC.td.

---

Full diff: https://github.com/llvm/llvm-project/pull/115548.diff

1 Files Affected:

• (modified) mlir/include/mlir/Dialect/EmitC/IR/EmitC.td (+2-2)

diff --git a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
index 7c84ab4dd39eb7..91916c1c4493dd 100644
--- a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
+++ b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
@@ -1110,9 +1110,9 @@ def EmitC_GlobalOp : EmitC_Op<"global", [Symbol]> {
 
     ```mlir
     // Global variable with an initial value.
-    emitc.global @x : emitc.array<2xf32> = dense<0.0, 2.0>
+    emitc.global @x : !emitc.array<2xf32> = dense<0.0, 2.0>
     // External global variable
-    emitc.global extern @x : emitc.array<2xf32>
+    emitc.global extern @x : !emitc.array<2xf32>
     // Constant global variable with internal linkage
     emitc.global static const @x : i32 = 0
     ```

[llvmbot]

@llvm/pr-subscribers-mlir-emitc

Author: Andrey Timonin (EtoAndruwa)

Changes

Missing ! before emitc.global was added in the EmitC.td.

---

Full diff: https://github.com/llvm/llvm-project/pull/115548.diff

1 Files Affected:

• (modified) mlir/include/mlir/Dialect/EmitC/IR/EmitC.td (+2-2)

diff --git a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
index 7c84ab4dd39eb7..91916c1c4493dd 100644
--- a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
+++ b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
@@ -1110,9 +1110,9 @@ def EmitC_GlobalOp : EmitC_Op<"global", [Symbol]> {
 
     ```mlir
     // Global variable with an initial value.
-    emitc.global @x : emitc.array<2xf32> = dense<0.0, 2.0>
+    emitc.global @x : !emitc.array<2xf32> = dense<0.0, 2.0>
     // External global variable
-    emitc.global extern @x : emitc.array<2xf32>
+    emitc.global extern @x : !emitc.array<2xf32>
     // Constant global variable with internal linkage
     emitc.global static const @x : i32 = 0
     ```

[EtoAndruwa]

It seems that something is wrong in the parser of emitc.global due to:

error: expected '>'
emitc.global @x : !emitc.array<2xf32> = dense<0.0, 2.0>

[EtoAndruwa]

It seems that something is wrong in the parser of emitc.global due to:

error: expected '>'
emitc.global @x : !emitc.array<2xf32> = dense<0.0, 2.0>

Wrong usage of dense here. Right example of usage is:

emitc.global @myglobal : !emitc.array<2xf32> = dense<4.000000e+00>
// CPP-DEFAULT: float myglobal[2] = {4.000000000e+00f, 4.000000000e+00f};
// CPP-DECLTOP: float myglobal[2] = {4.000000000e+00f, 4.000000000e+00f};

[EtoAndruwa]

It seems that something is wrong in the parser of emitc.global due to:

error: expected '>'
emitc.global @x : !emitc.array<2xf32> = dense<0.0, 2.0>

Wrong usage of dense here. Right example of usage is:

emitc.global @myglobal : !emitc.array<2xf32> = dense<4.000000e+00>
// CPP-DEFAULT: float myglobal[2] = {4.000000000e+00f, 4.000000000e+00f};
// CPP-DECLTOP: float myglobal[2] = {4.000000000e+00f, 4.000000000e+00f};

I guess author wanted to get something like:

int32_t global_array[3] = {0, 1, 2};

Therefore, the right version will be:

emitc.global @global_array : !emitc.array<3xi32> = dense<[0, 1, 2]>

[simon-camp]

Thanks!

[marbre]

Thanks!