Skip to content

[lldb] Disable TestCancelAttach for Windows host #115619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

slydiman
Copy link
Contributor

@slydiman slydiman commented Nov 9, 2024

See #115618 for details.

@llvmbot
Copy link
Member

llvmbot commented Nov 9, 2024

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

See #115618 for details.


Full diff: https://github.com/llvm/llvm-project/pull/115619.diff

1 Files Affected:

  • (modified) lldb/test/API/python_api/process/cancel_attach/TestCancelAttach.py (+5)
diff --git a/lldb/test/API/python_api/process/cancel_attach/TestCancelAttach.py b/lldb/test/API/python_api/process/cancel_attach/TestCancelAttach.py
index 9f643d50e58fc0..3be0a85d595002 100644
--- a/lldb/test/API/python_api/process/cancel_attach/TestCancelAttach.py
+++ b/lldb/test/API/python_api/process/cancel_attach/TestCancelAttach.py
@@ -14,6 +14,11 @@
 class AttachCancelTestCase(TestBase):
     NO_DEBUG_INFO_TESTCASE = True
 
+    @skipIf(
+        remote=True,
+        hostoslist=["windows"],
+        bugnumber="https://github.com/llvm/llvm-project/issues/115618",
+    )
     def test_scripted_implementation(self):
         """Test that cancelling a stuck "attach waitfor" works."""
         # First make an empty target for the attach:

@slydiman
Copy link
Contributor Author

Copy link
Collaborator

@labath labath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem might have something to do with the fact that this somehow ends up in the windows platform code:

return Status::FromErrorString("attach by name is not supported");
lldb_private::Process::DoAttachToProcessWithName(const char * process_name, const lldb_private::ProcessAttachInfo & attach_info) at \llvm-project\lldb\include\lldb\Target\Process.h(1011)
lldb_private::Process::Attach(lldb_private::ProcessAttachInfo & attach_info) at \llvm-project\lldb\source\Target\Process.cpp(2983)
lldb_private::PlatformWindows::Attach(lldb_private::ProcessAttachInfo & attach_info, lldb_private::Debugger & debugger, lldb_private::Target * target, lldb_private::Status & error) at \llvm-project\lldb\source\Plugins\Platform\Windows\PlatformWindows.cpp(562)

I would not have expected that in a remote test suite run.

@slydiman
Copy link
Contributor Author

slydiman commented Nov 11, 2024

@labath

The problem might have something to do with the fact that this somehow ends up in the windows platform code:

This callstack has no problem. It is the callstack on local Windows just for the comparison. I will remove this callstack from the issue description to avoid confusing.

The problem is the following:

Note process_sp = platform_sp->Attach(attach_info, GetDebugger(), this, error); at \llvm-project\lldb\source\Target\Target.cpp(3526)
runs gdbserver and puts vAttachWait command with LLDB-No-Such-Process to the event queue. But this packet never sent to the target (and no response). Something is wrong with listeners/broadcasters.

@slydiman slydiman merged commit 1277bea into llvm:main Nov 11, 2024
9 checks passed
Groverkss pushed a commit to iree-org/llvm-project that referenced this pull request Nov 15, 2024
@slydiman slydiman deleted the lldb-disable-TestCancelAttach branch April 18, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants