[VP] Refactoring some functions in ExpandVectorPredication.NFC #115840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiqinWeng
requested review from
jayfoad and
RKSimon
and removed request for
jayfoad
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
LiqinWeng
force-pushed
the
refactor-expeandvectorpredication
branch
2 times, most recently
from
9861320 to
959d184
Compare
LiqinWeng
force-pushed
the
refactor-expeandvectorpredication
branch
from
959d184 to
42575c4
Compare
|
Please can you improve the patch summary to describe the change, 'refactoring some functions' is too vague |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building vp intrinsic functions using a unified interface for expandPredicationToIntCall/expandPredicationToFPCall/expandPredicationToCastIntrinsic functions.