Skip to content

[llvm][ARM] Missing switch statement handles #116086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

nasherm
Copy link
Contributor

@nasherm nasherm commented Nov 13, 2024

PR #115153 added enums which needed to be handled in a switch statement. This trips up buildbot.

PR llvm#115153 added enums which needed to be handled in
a switch statement. This trips up buildbot.

Change-Id: Ic361cffb51a0924a77adc573fe653a30fe017a42
@llvmbot
Copy link
Member

llvmbot commented Nov 13, 2024

@llvm/pr-subscribers-backend-arm

Author: Nashe Mncube (nasherm)

Changes

PR #115153 added enums which needed to be handled in a switch statement. This trips up buildbot.


Full diff: https://github.com/llvm/llvm-project/pull/116086.diff

1 Files Affected:

  • (modified) llvm/lib/Target/ARM/ARMSubtarget.cpp (+2)
diff --git a/llvm/lib/Target/ARM/ARMSubtarget.cpp b/llvm/lib/Target/ARM/ARMSubtarget.cpp
index cec44acc544377..61c7fadb20aeb7 100644
--- a/llvm/lib/Target/ARM/ARMSubtarget.cpp
+++ b/llvm/lib/Target/ARM/ARMSubtarget.cpp
@@ -292,7 +292,9 @@ void ARMSubtarget::initSubtargetFeatures(StringRef CPU, StringRef FS) {
   case CortexR5:
   case CortexR7:
   case CortexM3:
+  case CortexM55:
   case CortexM7:
+  case CortexM85:
   case CortexR52:
   case CortexR52plus:
   case CortexX1:

Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for quickly fixing this!

@nasherm nasherm merged commit 57cf199 into llvm:main Nov 13, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants