Skip to content

[lldb] Fixed find-module.test in case of a remote target #116198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

slydiman
Copy link
Contributor

Changing from UNSUPPOERTED to XFAIL in #94165 break x86 linux host / Aarch64 linux target build https://lab.llvm.org/buildbot/#/builders/195/builds/1047

Changing from UNSUPPOERTED to XFAIL in llvm#94165 break x86 linux host / Aarch64 linux target build
https://lab.llvm.org/buildbot/#/builders/195/builds/1047
@slydiman slydiman added the lldb label Nov 14, 2024
@slydiman slydiman requested a review from labath November 14, 2024 10:14
@llvmbot
Copy link
Member

llvmbot commented Nov 14, 2024

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

Changing from UNSUPPOERTED to XFAIL in #94165 break x86 linux host / Aarch64 linux target build https://lab.llvm.org/buildbot/#/builders/195/builds/1047


Full diff: https://github.com/llvm/llvm-project/pull/116198.diff

1 Files Affected:

  • (modified) lldb/test/Shell/Minidump/Windows/find-module.test (+1-1)
diff --git a/lldb/test/Shell/Minidump/Windows/find-module.test b/lldb/test/Shell/Minidump/Windows/find-module.test
index fe457f4123522f..39d9dab4d346d6 100644
--- a/lldb/test/Shell/Minidump/Windows/find-module.test
+++ b/lldb/test/Shell/Minidump/Windows/find-module.test
@@ -1,7 +1,7 @@
 Test that we correctly find a PE/COFF file in our executable search path, and
 use it when opening minidumps.
 
-XFAIL: remote{{.*}}
+XFAIL: system-windows && remote-linux
 
 RUN: yaml2obj %S/Inputs/find-module.exe.yaml -o %T/find-module.exe
 RUN: yaml2obj %S/Inputs/find-module.dmp.yaml -o %T/find-module.dmp

Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was unsupported so it never ran on that bot. Then it was changed to xfail for remote, so it passed on one bot but was broken on another.

This change narrows the xfail to the one configuration that fails.

In that case, LGTM.

@slydiman slydiman merged commit 905256a into llvm:main Nov 14, 2024
9 checks passed
@slydiman slydiman deleted the fix2-lldb-find-module.test branch April 18, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants