Skip to content

Filter test based on backend support. #116244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

DanielKristofKiss
Copy link
Member

@DanielKristofKiss DanielKristofKiss commented Nov 14, 2024

ifunc support for Windows on AArch64 needs AArch64 support in the backend so restrict the test to it's availability.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Nov 14, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 14, 2024

@llvm/pr-subscribers-clang

Author: Daniel Kiss (DanielKristofKiss)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/116244.diff

1 Files Affected:

  • (modified) clang/test/CodeGen/ifunc-win.c (+2)
diff --git a/clang/test/CodeGen/ifunc-win.c b/clang/test/CodeGen/ifunc-win.c
index 7c9d6f6516c70f..deda51757e43be 100644
--- a/clang/test/CodeGen/ifunc-win.c
+++ b/clang/test/CodeGen/ifunc-win.c
@@ -3,6 +3,8 @@
 // RUN: %clang_cc1 -triple aarch64-pc-windows-msvc -fsanitize=thread -O2 -emit-llvm -o - %s | FileCheck %s --check-prefix=SAN
 // RUN: %clang_cc1 -triple aarch64-pc-windows-msvc -fsanitize=address -O2 -emit-llvm -o - %s | FileCheck %s --check-prefix=SAN
 
+// REQUIRES: aarch64-registered-target
+
 int foo(int) __attribute__ ((ifunc("foo_ifunc")));
 
 static int f1(int i) {

Copy link
Collaborator

@labrinea labrinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the title meant to say "backend"? Looks good, please add a short description, or correct the title for more clarity. Thanks!

@DanielKristofKiss DanielKristofKiss changed the title Filter test based on backed support. Filter test based on backend support. Nov 14, 2024
Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be good to land this ASAP so the bots get back to green.

@DanielKristofKiss DanielKristofKiss merged commit 44b33f5 into llvm:main Nov 14, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants