Skip to content

[memprof] Make ContextNode smaller #116271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024
Merged

[memprof] Make ContextNode smaller #116271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e954ab
[memprof] Make ContextNode smaller
kazutakahirata Jun 5, 2024
70a8218
Trigger build
kazutakahirata Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,10 @@ class CallsiteContextGraph {
// recursion.
bool Recursive = false;

// This will be formed by ORing together the AllocationType enum values
// for contexts including this node.
uint8_t AllocTypes = 0;

// The corresponding allocation or interior call. This is the primary call
// for which we have created this node.
CallInfo Call;
Expand All @@ -255,7 +259,7 @@ class CallsiteContextGraph {
// through cloning. I.e. located in the same function and have the same
// (possibly pruned) stack ids. They will be updated the same way as the
// primary call when assigning to function clones.
std::vector<CallInfo> MatchingCalls;
SmallVector<CallInfo, 0> MatchingCalls;

// For alloc nodes this is a unique id assigned when constructed, and for
// callsite stack nodes it is the original stack id when the node is
Expand All @@ -266,10 +270,6 @@ class CallsiteContextGraph {
// clones.
uint64_t OrigStackOrAllocId = 0;

// This will be formed by ORing together the AllocationType enum values
// for contexts including this node.
uint8_t AllocTypes = 0;

// Edges to all callees in the profiled call stacks.
// TODO: Should this be a map (from Callee node) for more efficient lookup?
std::vector<std::shared_ptr<ContextEdge>> CalleeEdges;
Expand Down
Loading