[lldb/Target] Add null-check before dereferencing inlined_info (NFC) #116300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is a follow-up to 9c7701f and adds extra-null checks before dereferencing the inlined_info pointer. Signed-off-by: Med Ismail Bennani <[email protected]>
medismailben
force-pushed
the
inlined-info-null-check
branch
from
cbd6cd7 to
fd5ba55
Compare
bulbazord
approved these changes
Nov 15, 2024
medismailben
added a commit
to medismailben/llvm-project
that referenced
this pull request
Nov 15, 2024
…lvm#116300) This patch is a follow-up to 9c7701f and adds extra-null checks before dereferencing the inlined_info pointer. Signed-off-by: Med Ismail Bennani <[email protected]> (cherry picked from commit 1857d29)
|
@llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) ChangesThis patch is a follow-up to 9c7701f and adds extra-null checks before dereferencing the inlined_info pointer. Full diff: https://github.com/llvm/llvm-project/pull/116300.diff 1 Files Affected:
diff --git a/lldb/source/Target/StackFrame.cpp b/lldb/source/Target/StackFrame.cpp
index 77179fec3ed438..1bca9786fb7c70 100644
--- a/lldb/source/Target/StackFrame.cpp
+++ b/lldb/source/Target/StackFrame.cpp
@@ -1239,7 +1239,8 @@ const char *StackFrame::GetFunctionName() {
if (inlined_block) {
const InlineFunctionInfo *inlined_info =
inlined_block->GetInlinedFunctionInfo();
- name = inlined_info->GetName().AsCString();
+ if (inlined_info)
+ name = inlined_info->GetName().AsCString();
}
}
@@ -1265,7 +1266,8 @@ const char *StackFrame::GetDisplayFunctionName() {
if (inlined_block) {
const InlineFunctionInfo *inlined_info =
inlined_block->GetInlinedFunctionInfo();
- name = inlined_info->GetDisplayName().AsCString();
+ if (inlined_info)
+ name = inlined_info->GetDisplayName().AsCString();
}
}
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a follow-up to 9c7701f and adds extra-null checks before dereferencing the inlined_info pointer.