Skip to content

[DebugInfo] Add DW_AT_artificial for compiler generated static member. #116327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[DebugInfo] Add DW_AT_artificial for compiler generated static member. #116327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/test/DebugInfo/Generic/artificial-static-member.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
; REQUIRES: x86_64-linux
; RUN: llc -O0 -filetype=obj < %s | \
Comment on lines +1 to 2
Copy link
Collaborator

@pogo59 pogo59 Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement will never be satisfied; the test will never run. You need a regular expression of the form target={{x86_64-.*-linux}} here.

But, it's probably better to remove the target triple clause from the IR, and add -triple=%itanium_target_triple to the llc command. Then you won't need a REQUIRES clause at all.

Copy link
Member Author

@CarlosAlbertoEnciso CarlosAlbertoEnciso Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pogo59 Thanks very much for your feedback.
I tried your second suggestion: -triple=%itanium_target_triple but llc raises the following error:

Unknown command line argument '-triple=%itanium_target_triple'.
llc: Did you mean '--mtriple=%itanium_target_triple'?

I looked at other test cases and it seems that it is valid only for clang:
// RUN: %clang_cc1 -triple %itanium_abi_triple ....

Created a new PR using the REQUIRES with a regular expression: #116429

; RUN: llvm-dwarfdump --debug-info - | FileCheck %s

Expand Down
Loading