[libc++] Stop uploading crash diagnostics in the CI #116581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to break the CI right now, and I've never once used those artifacts to debug something. In case of problems, we could always just modify a failing PR to include the required crash diagnostics in the artifacts as a one-off thing.
llvmbot
added
libc++
|
@llvm/pr-subscribers-github-workflow @llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesThis seems to break the CI right now, and I've never once used those artifacts to debug something. In case of problems, we could always just modify a failing PR to include the required crash diagnostics in the artifacts as a one-off thing. Full diff: https://github.com/llvm/llvm-project/pull/116581.diff 1 Files Affected:
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 472d18e73da78d..6275fc45721e09 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -43,7 +43,6 @@ env:
LLVM_OLDEST_VERSION: "17"
GCC_STABLE_VERSION: "13"
LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-19"
- CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
jobs:
stage1:
@@ -82,7 +81,6 @@ jobs:
**/CMakeConfigureLog.yaml
**/CMakeError.log
**/CMakeOutput.log
- **/crash_diagnostics/*
stage2:
if: github.repository_owner == 'llvm'
runs-on: libcxx-self-hosted-linux
@@ -128,7 +126,6 @@ jobs:
**/CMakeConfigureLog.yaml
**/CMakeError.log
**/CMakeOutput.log
- **/crash_diagnostics/*
stage3:
if: github.repository_owner == 'llvm'
needs: [ stage1, stage2 ]
@@ -192,7 +189,6 @@ jobs:
**/CMakeConfigureLog.yaml
**/CMakeError.log
**/CMakeOutput.log
- **/crash_diagnostics/*
macos:
needs: [ stage1 ]
@@ -235,7 +231,6 @@ jobs:
**/CMakeConfigureLog.yaml
**/CMakeError.log
**/CMakeOutput.log
- **/crash_diagnostics/*
windows:
runs-on: windows-2022
|
|
I think #116580 is actually what we want here, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to break the CI right now, and I've never once used those artifacts to debug something. In case of problems, we could always just modify a failing PR to include the required crash diagnostics in the artifacts as a one-off thing.