Skip to content

[MISched] Use right boundary when trying latency heuristics #116592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

wangpc-pp
Copy link
Contributor

We may do bottom-up or bidirectional scheduling but previously we
assume we are doing top-down scheduling, which may cause some issues.

Copy link
Member

@mshockwave mshockwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this doesn't cause a crash, do you have any example that shows inferior scheduling, which potentially can be a test case?

@mshockwave
Copy link
Member

I suppose this doesn't cause a crash, do you have any example that shows inferior scheduling, which potentially can be a test case?

do you by any chance have a test?

@wangpc-pp
Copy link
Contributor Author

I suppose this doesn't cause a crash, do you have any example that shows inferior scheduling, which potentially can be a test case?

do you by any chance have a test?

Not yet. Actually I did this change not because I met some problems. I did find a problem when handling clustering/fusion in post-ra scheduling, which should be fixed by #116584. Then I just checked other heuristics to see if there may be some other issues, and I found this one. I don't know if I can write a test, the problen here and the fix are clear (we should use the right boundary for different directions).

Copy link
Contributor

@michaelmaitland michaelmaitland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is what GenericScheduler does in tryCandidate for tryLatency, so I think it makes sense to take it too.

We may do bottom-up or bidirectional scheduling but previously we
assume we are doing top-down scheduling, which may cause some issues.
@wangpc-pp wangpc-pp force-pushed the main-postra-sched-latency-boundary branch from 0d333a5 to 646c6a0 Compare November 27, 2024 06:45
@wangpc-pp wangpc-pp merged commit 3618c99 into llvm:main Nov 27, 2024
5 of 7 checks passed
@wangpc-pp wangpc-pp deleted the main-postra-sched-latency-boundary branch November 27, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants